Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bullet-featherstone] Ignore collision between static objects and objects with world joint #611

Merged
merged 4 commits into from
Apr 4, 2024

Conversation

iche033
Copy link
Contributor

@iche033 iche033 commented Mar 27, 2024

🎉 New feature

Summary

Skip collision checking between collisions in 1) a static model 2) a fixed base link, and 3) a non base link with zero dofs.

This is done by setting the collision filter mask / flags to use the StaticFilter, which is already done for static objects (<static>true</static>), i.e. static objects already ignore collisions with each other.

This is for perf optimization. When you have overlapping complex meshes with fixed world joints, they would cause a perf hit and these changes would allow bullet to skip collision checking between them.

Added a test in collisions.cc that checks contacts between static objects and objects with fixed world joint.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@github-actions github-actions bot added the 🎵 harmonic Gazebo Harmonic label Mar 27, 2024
Copy link

codecov bot commented Mar 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.35%. Comparing base (d616379) to head (8841d70).

Additional details and impacted files
@@               Coverage Diff               @@
##           gz-physics7     #611      +/-   ##
===============================================
+ Coverage        78.33%   78.35%   +0.01%     
===============================================
  Files              140      140              
  Lines             8072     8079       +7     
===============================================
+ Hits              6323     6330       +7     
  Misses            1749     1749              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@iche033
Copy link
Contributor Author

iche033 commented Mar 28, 2024

homebrew build failed. A closer inspection found that the DetachableJointTest/0.CorrectAttachmentPoints also started failing in the gz-physics7 and main branches this week - this is dartsim plugin and there haven't been changes to dartsim implementation recently.

I found that there is a new ode 0.16.5 bottle this week, which dartsim 6.13.2_2 depends on - not sure if it's caused by this.

@scpeters
Copy link
Member

homebrew build failed. A closer inspection found that the DetachableJointTest/0.CorrectAttachmentPoints also started failing in the gz-physics7 and main branches this week - this is dartsim plugin and there haven't been changes to dartsim implementation recently.

I found that there is a new ode 0.16.5 bottle this week, which dartsim 6.13.2_2 depends on - not sure if it's caused by this.

it looks like some ode build configuration options were removed in https://github.com/Homebrew/homebrew-core/pull/167158/files#diff-740579038a60e496fde8245acb12845f8c4784bb2f5a891ee126926e99187b20L36-L39

Copy link
Contributor

@azeey azeey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of minor issues. Otherwise, LGTM!

bullet-featherstone/src/SDFFeatures.cc Outdated Show resolved Hide resolved
test/common_test/collisions.cc Outdated Show resolved Hide resolved
test/common_test/collisions.cc Outdated Show resolved Hide resolved
Signed-off-by: Ian Chen <[email protected]>
@iche033 iche033 merged commit 2bc19ad into gz-physics7 Apr 4, 2024
9 of 10 checks passed
@iche033 iche033 deleted the bullet_static_fixed_col branch April 4, 2024 17:27
@iche033 iche033 added the Bullet Bullet engine label Jun 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bullet Bullet engine 🎵 harmonic Gazebo Harmonic
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants