feat: allow passing metadata in nwc pay_invoice and multi_pay_invoice #270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -127,6 +127,7 @@ export type Nip47Notification = | |||
|
|
|||
| export type Nip47PayInvoiceRequest = { | |||
| invoice: string; | |||
| metadata?: unknown; | |||
There was a problem hiding this comment.
instead of unknown couldn't be an empty object or something?
There was a problem hiding this comment.
i had this demo website to pass lud 18 metadata to extension:https://github.com/pavanjoshi914/Buy-Songs might be outdated
There was a problem hiding this comment.
@pavanjoshi914 an empty object won't work, it will create issues when you actually try to pass an object with properties set.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alby Hub can store this data, enabling interesting applications to be developed, and finally enable a nice way to store payment metadata.