Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow passing metadata in nwc pay_invoice and multi_pay_invoice #270

Merged
merged 2 commits into from
Nov 28, 2024
Merged

feat: allow passing metadata in nwc pay_invoice and multi_pay_invoice #270

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c3df01d
feat: allow passing metadata in nwc pay_invoice and multi_pay_invoice
rolznz Nov 27, 2024
a05b58e
Merge branch 'master' into feat/pay-invoice-metadata
rolznz Nov 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/NWCClient.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,6 +127,7 @@ export type Nip47Notification =

export type Nip47PayInvoiceRequest = {
invoice: string;
metadata?: unknown;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

instead of unknown couldn't be an empty object or something?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i had this demo website to pass lud 18 metadata to extension:https://github.com/pavanjoshi914/Buy-Songs might be outdated

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pavanjoshi914 an empty object won't work, it will create issues when you actually try to pass an object with properties set.

amount?: number; // msats
};

Expand Down