Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui): Add release bubbles support to TimeSeriesWidgetVisualization #85270

Open
wants to merge 24 commits into
base: master
Choose a base branch
from

Conversation

billyvg
Copy link
Member

@billyvg billyvg commented Feb 14, 2025

Adds release bubbles to <TimeSeriesWidgetVisualization
image

Clicking on a bubble opens up a drawer.
image

requires #86076
ref: #85775

@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Feb 14, 2025
Copy link

codecov bot commented Feb 14, 2025

❌ 13 Tests Failed:

Tests completed Failed Passed Skipped
9637 13 9624 4
View the top 3 failed test(s) by shortest run time
latencyChart renders
Stack Traces | 0.077s run time
Error: Expected test not to call console.error().

If the error is expected, test for it explicitly by mocking it out using jest.spyOn(console, 'error').mockImplementation() and test that the warning occurs.



Error: No mocked response found for request: GET .../org-slug/releases/stats/
    at processTimers (node:internal/timers:526:9)
    at console.captureMessage [as error] (.../node_modules/jest-fail-on-console/index.js:83:25)
    at Object.<anonymous> (.../app/__mocks__/api.tsx:45:15)
    at Promise.then.completed (.../jest-circus/build/utils.js:298:28)
    at new Promise (<anonymous>)
    at callAsyncCircusFn (.../jest-circus/build/utils.js:231:10)
    at _callCircusHook (.../jest-circus/build/run.js:281:40)
    at _runTest (.../jest-circus/build/run.js:254:5)
    at _runTestsForDescribeBlock (.../jest-circus/build/run.js:126:9)
    at _runTestsForDescribeBlock (.../jest-circus/build/run.js:121:9)
    at run (.../jest-circus/build/run.js:71:3)
    at runAndTransformResultsToJestFormat (.../build/legacy-code-todo-rewrite/jestAdapterInit.js:122:21)
    at jestAdapter (.../build/legacy-code-todo-rewrite/jestAdapter.js:79:19)
    at runTestInternal (.../jest-runner/build/runTest.js:367:16)
    at runTest (.../jest-runner/build/runTest.js:444:34)
    at Object.worker (.../jest-runner/build/testWorker.js:106:12)
    at flushUnexpectedConsoleCalls (.../node_modules/jest-fail-on-console/index.js:48:13)
    at Object.<anonymous> (.../node_modules/jest-fail-on-console/index.js:139:7)
    at Promise.then.completed (.../jest-circus/build/utils.js:298:28)
    at new Promise (<anonymous>)
    at callAsyncCircusFn (.../jest-circus/build/utils.js:231:10)
    at _callCircusHook (.../jest-circus/build/run.js:281:40)
    at _runTest (.../jest-circus/build/run.js:254:5)
    at _runTestsForDescribeBlock (.../jest-circus/build/run.js:126:9)
    at _runTestsForDescribeBlock (.../jest-circus/build/run.js:121:9)
    at run (.../jest-circus/build/run.js:71:3)
    at runAndTransformResultsToJestFormat (.../build/legacy-code-todo-rewrite/jestAdapterInit.js:122:21)
    at jestAdapter (.../build/legacy-code-todo-rewrite/jestAdapter.js:79:19)
    at runTestInternal (.../jest-runner/build/runTest.js:367:16)
    at runTest (.../jest-runner/build/runTest.js:444:34)
    at Object.worker (.../jest-runner/build/testWorker.js:106:12)
throughputChart renders
Stack Traces | 0.077s run time
Error: Expected test not to call console.error().

If the error is expected, test for it explicitly by mocking it out using jest.spyOn(console, 'error').mockImplementation() and test that the warning occurs.



Error: No mocked response found for request: GET .../org-slug/releases/stats/
    at processTimers (node:internal/timers:529:7)
    at console.captureMessage [as error] (.../node_modules/jest-fail-on-console/index.js:83:25)
    at Object.<anonymous> (.../app/__mocks__/api.tsx:45:15)
    at Promise.then.completed (.../jest-circus/build/utils.js:298:28)
    at new Promise (<anonymous>)
    at callAsyncCircusFn (.../jest-circus/build/utils.js:231:10)
    at _callCircusHook (.../jest-circus/build/run.js:281:40)
    at _runTest (.../jest-circus/build/run.js:254:5)
    at _runTestsForDescribeBlock (.../jest-circus/build/run.js:126:9)
    at _runTestsForDescribeBlock (.../jest-circus/build/run.js:121:9)
    at run (.../jest-circus/build/run.js:71:3)
    at runAndTransformResultsToJestFormat (.../build/legacy-code-todo-rewrite/jestAdapterInit.js:122:21)
    at jestAdapter (.../build/legacy-code-todo-rewrite/jestAdapter.js:79:19)
    at runTestInternal (.../jest-runner/build/runTest.js:367:16)
    at runTest (.../jest-runner/build/runTest.js:444:34)
    at Object.worker (.../jest-runner/build/testWorker.js:106:12)
    at flushUnexpectedConsoleCalls (.../node_modules/jest-fail-on-console/index.js:48:13)
    at Object.<anonymous> (.../node_modules/jest-fail-on-console/index.js:139:7)
    at Promise.then.completed (.../jest-circus/build/utils.js:298:28)
    at new Promise (<anonymous>)
    at callAsyncCircusFn (.../jest-circus/build/utils.js:231:10)
    at _callCircusHook (.../jest-circus/build/run.js:281:40)
    at _runTest (.../jest-circus/build/run.js:254:5)
    at _runTestsForDescribeBlock (.../jest-circus/build/run.js:126:9)
    at _runTestsForDescribeBlock (.../jest-circus/build/run.js:121:9)
    at run (.../jest-circus/build/run.js:71:3)
    at runAndTransformResultsToJestFormat (.../build/legacy-code-todo-rewrite/jestAdapterInit.js:122:21)
    at jestAdapter (.../build/legacy-code-todo-rewrite/jestAdapter.js:79:19)
    at runTestInternal (.../jest-runner/build/runTest.js:367:16)
    at runTest (.../jest-runner/build/runTest.js:444:34)
    at Object.worker (.../jest-runner/build/testWorker.js:106:12)
HTTPSummaryPage fetches module data
Stack Traces | 0.351s run time
Error: Expected test not to call console.error().

If the error is expected, test for it explicitly by mocking it out using jest.spyOn(console, 'error').mockImplementation() and test that the warning occurs.



Error: No mocked response found for request: GET .../org-slug/releases/stats/
    at processTimers (node:internal/timers:529:7)
    at console.captureMessage [as error] (.../node_modules/jest-fail-on-console/index.js:83:25)
    at Object.<anonymous> (.../app/__mocks__/api.tsx:45:15)
    at Promise.then.completed (.../jest-circus/build/utils.js:298:28)
    at new Promise (<anonymous>)
    at callAsyncCircusFn (.../jest-circus/build/utils.js:231:10)
    at _callCircusHook (.../jest-circus/build/run.js:281:40)
    at _runTest (.../jest-circus/build/run.js:254:5)
    at _runTestsForDescribeBlock (.../jest-circus/build/run.js:126:9)
    at _runTestsForDescribeBlock (.../jest-circus/build/run.js:121:9)
    at run (.../jest-circus/build/run.js:71:3)
    at runAndTransformResultsToJestFormat (.../build/legacy-code-todo-rewrite/jestAdapterInit.js:122:21)
    at jestAdapter (.../build/legacy-code-todo-rewrite/jestAdapter.js:79:19)
    at runTestInternal (.../jest-runner/build/runTest.js:367:16)
    at runTest (.../jest-runner/build/runTest.js:444:34)
    at Object.worker (.../jest-runner/build/testWorker.js:106:12)
    at flushUnexpectedConsoleCalls (.../node_modules/jest-fail-on-console/index.js:48:13)
    at Object.<anonymous> (.../node_modules/jest-fail-on-console/index.js:139:7)
    at Promise.then.completed (.../jest-circus/build/utils.js:298:28)
    at new Promise (<anonymous>)
    at callAsyncCircusFn (.../jest-circus/build/utils.js:231:10)
    at _callCircusHook (.../jest-circus/build/run.js:281:40)
    at _runTest (.../jest-circus/build/run.js:254:5)
    at _runTestsForDescribeBlock (.../jest-circus/build/run.js:126:9)
    at _runTestsForDescribeBlock (.../jest-circus/build/run.js:121:9)
    at run (.../jest-circus/build/run.js:71:3)
    at runAndTransformResultsToJestFormat (.../build/legacy-code-todo-rewrite/jestAdapterInit.js:122:21)
    at jestAdapter (.../build/legacy-code-todo-rewrite/jestAdapter.js:79:19)
    at runTestInternal (.../jest-runner/build/runTest.js:367:16)
    at runTest (.../jest-runner/build/runTest.js:444:34)
    at Object.worker (.../jest-runner/build/testWorker.js:106:12)

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

@billyvg billyvg force-pushed the feat-ui-release-bubbles branch from 9f72f97 to 3a6a222 Compare February 26, 2025 16:37
@billyvg billyvg force-pushed the feat-ui-release-bubbles branch 2 times, most recently from 45793f5 to 1af0aea Compare February 27, 2025 01:18
@billyvg billyvg changed the title feat(ui): Add id property to eCharts bar/line series feat(ui): Add release bubbles support to TimeSeriesWidgetVisualization Feb 27, 2025
Copy link

codecov bot commented Feb 27, 2025

Bundle Report

Changes will increase total bundle size by 51.37kB (0.12%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
app-webpack-bundle-array-push 41.73MB 51.37kB (0.12%) ⬆️

Affected Assets, Files, and Routes:

view changes for bundle: app-webpack-bundle-array-push

Assets Changed:

Asset Name Size Change Total Size Change (%)
chunks/app_components_avatar_actorAvatar_tsx-app_components_avatar_avatarList_tsx-app_components_cha-e41958.*.js 3.67kB 1.38MB 0.27%
chunks/app_views_issueDetails_groupEventDetails_groupEventDetails_tsx.*.js -8.23kB 353.36kB -2.28%
chunks/app_components_events_eventEntries_tsx.*.js -14.34kB 235.24kB -5.74%
chunks/app_views_traces_content_tsx-node_modules_lodash_omitBy_js.*.js (New) 134.02kB 134.02kB 100.0% 🚀
entrypoints/app.js 19 bytes 109.19kB 0.02%
chunks/app_views_performance_transactionSummary_transactionSpans_spanDetails_index_tsx.*.js -1.55kB 69.94kB -2.17%
chunks/app_views_performance_transactionSummary_pageLayout_tsx.*.js 12 bytes 69.26kB 0.02%
chunks/app_components_charts_components_dataZoomInside_tsx-app_components_charts_components_toolBox_-f1e542.*.js (New) 49.21kB 49.21kB 100.0% 🚀
chunks/app_components_charts_components_dataZoomInside_tsx-app_components_charts_components_toolBox_-f7da41.*.js 5.01kB 46.46kB 12.09% ⚠️
chunks/app_views_stories_index_tsx.*.js 1.52kB 44.92kB 3.5%
chunks/app_views_dashboards_contexts_widgetSyncContext_tsx-app_views_insights_browser_webVitals_view-ffe0ab.*.js -1.56kB 44.85kB -3.36%
chunks/app_components_charts_components_dataZoomInside_tsx-app_components_charts_components_toolBox_-5531f4.*.js 73 bytes 40.67kB 0.18%
chunks/app_views_insights_mobile_screens_views_screensLandingPage_tsx-app_views_insights_pages_domai-598e4f.*.js 12 bytes 39.13kB 0.03%
chunks/app_components_feedback_widget_us*kWidget_tsx-app_views_performance_transactionSummary-51d702.93d4fab8c49d3bd74395.js (New) 37.51kB 37.51kB 100.0% 🚀
chunks/app_components_charts_components_dataZoomInside_tsx-app_components_charts_components_toolBox_-51a8df.*.js 73 bytes 37.26kB 0.2%
chunks/app_views_insights_pages_backend_backendOverviewPage_tsx-node_modules_lodash_partialRight_js.*.js -18 bytes 36.92kB -0.05%
chunks/app_components_charts_areaChart_tsx-app_components_charts_series_scatterSeries_tsx-app_compon-91e88c.*.js (New) 36.18kB 36.18kB 100.0% 🚀
chunks/app_components_charts_series_scatterSeries_tsx-app_components_feedback_widget_us*kWidg-4fd237.d11a63317d35e92b4235.js (New) 35.73kB 35.73kB 100.0% 🚀
chunks/app_components_charts_components_dataZoomInside_tsx-app_components_charts_components_toolBox_-b3f1e2.*.js 73 bytes 35.73kB 0.2%
chunks/app_components_replays_renderSortableHeaderCell_tsx-app_components_replays_useQueryBasedSorti-8653be.*.js (New) 34.98kB 34.98kB 100.0% 🚀
chunks/app_components_feedback_widget_feedbackWidgetButton_tsx-app_views_insights_common_components_-07f64e.*.js -30 bytes 34.23kB -0.09%
chunks/app_components_replays_renderSortableHeaderCell_tsx-app_components_replays_useQueryBasedSorti-dd1356.*.js (New) 32.82kB 32.82kB 100.0% 🚀
chunks/app_views_insights_common_components_modulePageFilterBar_tsx-app_views_insights_common_compon-5dd5b5.*.js 12 bytes 31.9kB 0.04%
chunks/app_components_charts_components_dataZoomInside_tsx-app_components_charts_components_toolBox_-a58c5e.*.js (New) 31.31kB 31.31kB 100.0% 🚀
chunks/app_components_charts_eventsRequest_tsx-app_components_feedback_widget_us*kWidget_tsx--fbb1b9.19640b842f91323df3f6.js (New) 31.1kB 31.1kB 100.0% 🚀
chunks/app_components_charts_areaChart_tsx-app_components_charts_series_scatterSeries_tsx-app_compon-62bd3d.*.js (New) 29.21kB 29.21kB 100.0% 🚀
chunks/app_views_insights_uptime_views_overview_tsx.*.js 12 bytes 28.39kB 0.04%
chunks/app_views_dashboards_widgets_timeSeriesWidget_timeSeriesWidgetVisualization_tsx.*.js 11.88kB 27.98kB 73.78% ⚠️
chunks/app_components_charts_components_dataZoomInside_tsx-app_components_charts_components_toolBox_-da34cb.*.js (New) 27.83kB 27.83kB 100.0% 🚀
chunks/app_components_charts_chartZoom_tsx-app_components_charts_lineChart_tsx-app_components_charts-21bdfd.*.js 12 bytes 27.05kB 0.04%
chunks/app_components_feedback_widget_us*kWidget_tsx-app_components_performance_transactionSe-feae7d.c897283465b5b93c26e6.js (New) 24.18kB 24.18kB 100.0% 🚀
chunks/app_components_charts_components_dataZoomInside_tsx-app_components_charts_components_toolBox_-4f9b0b.*.js 1.62kB 23.5kB 7.41% ⚠️
chunks/app_views_insights_common_components_headerContainer_tsx-app_views_insights_common_components-693866.*.js 12 bytes 19.73kB 0.06%
chunks/app_views_insights_database_views_databaseLandingPage_tsx.*.js -213 bytes 18.97kB -1.11%
chunks/app_views_insights_common_components_insightsLineChartWidget_tsx-app_views_insights_common_co-e286d9.*.js -1.48kB 18.76kB -7.29%
chunks/app_components_replays_renderSortableHeaderCell_tsx-app_components_replays_useQueryBasedSorti-b49528.*.js (New) 18.15kB 18.15kB 100.0% 🚀
chunks/app_components_core_alert_alertLink_tsx-app_views_insights_crons_views_overview_tsx.*.js 12 bytes 17.97kB 0.07%
chunks/app_components_replays_renderSortableHeaderCell_tsx-app_components_replays_useQueryBasedSorti-f70b67.*.js (New) 17.93kB 17.93kB 100.0% 🚀
chunks/app_components_feedback_widget_us*kWidget_tsx-app_utils_discover_discoverQuery_tsx-app-c5fefe.6a09b4e44cd7045b2957.js (New) 17.41kB 17.41kB 100.0% 🚀
chunks/app_components_feedback_widget_us*kWidget_tsx-app_components_gridEditable_sortLink_tsx-d372f4.73d068ae4d7174d5282a.js (New) 16.21kB 16.21kB 100.0% 🚀
chunks/app_components_events_interfaces_llm-monitoring_llmMonitoringSection_tsx-node_modules_lodash_-e6ded3.*.js (New) 16.19kB 16.19kB 100.0% 🚀
chunks/app_views_insights_common_components_tableCells_spanDescriptionCell_tsx.*.js (New) 15.7kB 15.7kB 100.0% 🚀
chunks/app_views_replays_deadRageClick_deadRageSelectorCards_tsx.*.js (New) 15.26kB 15.26kB 100.0% 🚀
chunks/app_components_events_interfaces_crashContent_exception_actionableItems_tsx-app_components_ev-206916.*.js (New) 15.03kB 15.03kB 100.0% 🚀
chunks/app_components_charts_components_dataZoomInside_tsx-app_components_charts_components_toolBox_-79f51f.*.js (New) 14.82kB 14.82kB 100.0% 🚀
chunks/app_components_feedback_widget_us*kWidget_tsx-app_components_performance_transactionSe-f61270.e959059b7397b84ed114.js (New) 13.36kB 13.36kB 100.0% 🚀
chunks/app_components_charts_lineChart_tsx-app_components_feedback_widget_us*kWidget_tsx-app_-26fc43.9b279129bedf0f14f24b.js (New) 12.34kB 12.34kB 100.0% 🚀
chunks/app_components_charts_baseChart_tsx-app_components_charts_series_barSeries_tsx.*.js 206 bytes 11.31kB 1.86%
chunks/vendors-node_modules_echarts_lib_chart_scatter_js-node_modules_echarts_lib_component_dataZoom-4f3bc4.*.js 104 bytes 10.76kB 0.98%
chunks/app_components_replays_renderSortableHeaderCell_tsx-app_components_replays_useQueryBasedSorti-988c82.*.js (New) 10.44kB 10.44kB 100.0% 🚀
chunks/app_views_insights_mobile_screenload_components_screensView_tsx.*.js (New) 9.87kB 9.87kB 100.0% 🚀
chunks/vendors-node_modules_lodash_max_js-node_modules_lodash_min_js-node_modules_lodash_partialRigh-530812.*.js (New) 9.4kB 9.4kB 100.0% 🚀
chunks/vendors-node_modules_echarts_lib_component_dataZoomInside_js-node_modules_lodash_partialRight-e5351f0.*.js 104 bytes 8.91kB 1.18%
chunks/vendors-node_modules_echarts_lib_component_dataZoomInside_js-node_modules_lodash_partialRight-e5351f3.*.js 104 bytes 8.91kB 1.18%
chunks/vendors-node_modules_echarts_lib_component_dataZoomInside_js-node_modules_lodash_partialRight-e5351f1.*.js 104 bytes 8.91kB 1.18%
chunks/vendors-node_modules_echarts_lib_component_dataZoomInside_js-node_modules_lodash_partialRight-e5351f2.*.js 104 bytes 8.91kB 1.18%
chunks/vendors-node_modules_echarts_lib_component_dataZoomInside_js-node_modules_lodash_partialRight-e5351f4.*.js 104 bytes 8.91kB 1.18%
chunks/vendors-node_modules_echarts_lib_component_dataZoomInside_js-node_modules_lodash_partialRight-e5351f6.*.js (New) 8.91kB 8.91kB 100.0% 🚀
chunks/vendors-node_modules_echarts_lib_component_dataZoomInside_js-node_modules_lodash_partialRight-e5351f5.*.js 104 bytes 8.91kB 1.18%
chunks/app_utils_replays_hooks_useDeadRageSelectors_tsx-app_views_replays_deadRageClick_selectorTable_tsx.*.js -1.19kB 8.8kB -11.91%
chunks/app_components_events_eventDrawer_tsx.*.js (New) 8.68kB 8.68kB 100.0% 🚀
chunks/app_views_traces_styles_tsx.*.js (New) 4.56kB 4.56kB 100.0% 🚀
chunks/app_views_traces_content_tsx-node_modules_lodash_omitBy_js-node_modules_lodash_partialRight_j-d4a98b.*.js (Deleted) -135.31kB 0 bytes -100.0% 🗑️
chunks/app_components_charts_components_dataZoomInside_tsx-app_components_charts_components_toolBox_-fcfb5f.*.js (Deleted) -47.01kB 0 bytes -100.0% 🗑️
chunks/app_components_feedback_widget_us*kWidget_tsx-app_views_performance_transactionSummary-51d702.02885281f5c6c4001c00.js (Deleted) -37.51kB 0 bytes -100.0% 🗑️
chunks/app_components_charts_series_scatterSeries_tsx-app_components_feedback_widget_us*kWidg-2f9105.43c17cbc856adb018662.js (Deleted) -34.19kB 0 bytes -100.0% 🗑️
chunks/app_components_charts_areaChart_tsx-app_components_charts_series_scatterSeries_tsx-app_compon-4b7996.*.js (Deleted) -34.01kB 0 bytes -100.0% 🗑️
chunks/app_utils_discover_discoverQuery_tsx-app_views_replays_list_tsx-node_modules_invariant_browser_js.*.js (Deleted) -32.01kB 0 bytes -100.0% 🗑️
chunks/app_views_performance_content_tsx-node_modules_echarts_lib_chart_scatter_js-node_modules_echa-b40361.*.js (Deleted) -31.38kB 0 bytes -100.0% 🗑️
chunks/app_components_charts_eventsRequest_tsx-app_components_feedback_widget_us*kWidget_tsx--fbb1b9.a291e7cf6b8b3ceee157.js (Deleted) -31.1kB 0 bytes -100.0% 🗑️
chunks/app_components_charts_areaChart_tsx-app_components_charts_series_scatterSeries_tsx-app_compon-a78653.*.js (Deleted) -28.73kB 0 bytes -100.0% 🗑️
chunks/app_components_charts_components_dataZoomInside_tsx-app_components_charts_components_toolBox_-440387.*.js (Deleted) -26.97kB 0 bytes -100.0% 🗑️
chunks/app_components_feedback_widget_us*kWidget_tsx-app_components_performance_transactionSe-feae7d.6002db75f55e26da12c3.js (Deleted) -24.18kB 0 bytes -100.0% 🗑️
chunks/app_views_dashboards_widgets_timeSeriesWidget_timeSeriesWidgetVisualization_stories_tsx.*.js (Deleted) -18.72kB 0 bytes -100.0% 🗑️
chunks/app_components_feedback_widget_us*kWidget_tsx-app_utils_discover_discoverQuery_tsx-app-c5fefe.b515aab9e885a6bbae50.js (Deleted) -17.41kB 0 bytes -100.0% 🗑️
chunks/app_components_gridEditable_sortLink_tsx-app_views_insights_common_components_tableCells_span-cdac7b.*.js (Deleted) -17.3kB 0 bytes -100.0% 🗑️
chunks/app_views_insights_pages_mobile_mobileOverviewPage_tsx.*.js (Deleted) -16.64kB 0 bytes -100.0% 🗑️
chunks/app_views_insights_pages_frontend_frontendOverviewPage_tsx.*.js (Deleted) -16.43kB 0 bytes -100.0% 🗑️
chunks/app_components_feedback_widget_us*kWidget_tsx-app_components_gridEditable_sortLink_tsx-d372f4.286ad599958e33ebc2a9.js (Deleted) -16.21kB 0 bytes -100.0% 🗑️
chunks/app_views_replays_deadRageClick_deadRageSelectorCards_tsx-app_utils_versions_semverCompare_ts.*.js (Deleted) -15.55kB 0 bytes -100.0% 🗑️
chunks/app_components_feedback_widget_us*kWidget_tsx-app_components_performance_transactionSe-f61270.99d49f871bc4b25eccb9.js (Deleted) -13.36kB 0 bytes -100.0% 🗑️
chunks/app_components_charts_components_dataZoomInside_tsx-app_components_charts_components_toolBox_-01ad31.*.js (Deleted) -12.52kB 0 bytes -100.0% 🗑️
chunks/app_components_charts_lineChart_tsx-app_components_feedback_widget_us*kWidget_tsx-app_-26fc43.66a0052d99e0e1145986.js (Deleted) -12.34kB 0 bytes -100.0% 🗑️
chunks/app_components_gridEditable_sortLink_tsx-app_views_insights_mobile_screenload_components_scre-1ff55c.*.js (Deleted) -11.5kB 0 bytes -100.0% 🗑️
chunks/app_components_events_interfaces_llm-monitoring_llmMonitoringSection_tsx-app_views_insights_c-ad85ed.*.js (Deleted) -11.15kB 0 bytes -100.0% 🗑️
chunks/vendors-node_modules_echarts_lib_chart_scatter_js-node_modules_echarts_lib_component_dataZoom-1148da.*.js (Deleted) -10.53kB 0 bytes -100.0% 🗑️
chunks/app_utils_discover_discoverQuery_tsx-app_views_replays_deadRageClick_deadRageClickList_tsx.*.js (Deleted) -7.68kB 0 bytes -100.0% 🗑️
chunks/app_views_insights_common_components_insightsLineChartWidget_tsx-app_views_insights_common_co-9de3f2.*.js (Deleted) -5.77kB 0 bytes -100.0% 🗑️
chunks/app_views_traces_styles_tsx-node_modules_lodash_max_js-node_modules_lodash_min_js.*.js (Deleted) -5.17kB 0 bytes -100.0% 🗑️
chunks/app_views_dashboards_contexts_widgetSyncContext_stories_tsx.*.js (Deleted) -2.65kB 0 bytes -100.0% 🗑️

Files in chunks/app_views_performance_transactionSummary_pageLayout_tsx.*.js:

  • ./app/views/insights/pages/domainViewHeader.tsx → Total Size: 12.44kB

Files in chunks/app_components_charts_components_dataZoomInside_tsx-app_components_charts_components_toolBox_-f1e542.*.js:

  • ./app/views/insights/pages/domainViewHeader.tsx → Total Size: 12.44kB

Files in chunks/app_components_charts_components_dataZoomInside_tsx-app_components_charts_components_toolBox_-f7da41.*.js:

  • ./app/views/insights/pages/domainViewHeader.tsx → Total Size: 12.44kB

Files in chunks/app_views_insights_mobile_screens_views_screensLandingPage_tsx-app_views_insights_pages_domai-598e4f.*.js:

  • ./app/views/insights/pages/domainViewHeader.tsx → Total Size: 12.44kB

Files in chunks/app_views_insights_pages_backend_backendOverviewPage_tsx-node_modules_lodash_partialRight_js.*.js:

  • ./app/views/insights/pages/domainViewHeader.tsx → Total Size: 12.44kB

Files in chunks/app_views_insights_common_components_modulePageFilterBar_tsx-app_views_insights_common_compon-5dd5b5.*.js:

  • ./app/views/insights/pages/domainViewHeader.tsx → Total Size: 12.44kB

Files in chunks/app_views_insights_uptime_views_overview_tsx.*.js:

  • ./app/views/insights/pages/domainViewHeader.tsx → Total Size: 12.44kB

Files in chunks/app_components_charts_chartZoom_tsx-app_components_charts_lineChart_tsx-app_components_charts-21bdfd.*.js:

  • ./app/views/insights/pages/domainViewHeader.tsx → Total Size: 12.44kB

Files in chunks/app_views_insights_common_components_headerContainer_tsx-app_views_insights_common_components-693866.*.js:

  • ./app/views/insights/pages/domainViewHeader.tsx → Total Size: 12.44kB

Files in chunks/app_components_replays_renderSortableHeaderCell_tsx-app_components_replays_useQueryBasedSorti-b49528.*.js:

  • ./app/views/insights/pages/domainViewHeader.tsx → Total Size: 12.44kB

Files in chunks/app_components_core_alert_alertLink_tsx-app_views_insights_crons_views_overview_tsx.*.js:

  • ./app/views/insights/pages/domainViewHeader.tsx → Total Size: 12.44kB

Files in chunks/app_components_replays_renderSortableHeaderCell_tsx-app_components_replays_useQueryBasedSorti-f70b67.*.js:

  • ./app/views/insights/pages/domainViewHeader.tsx → Total Size: 12.44kB

Files in chunks/app_components_charts_baseChart_tsx-app_components_charts_series_barSeries_tsx.*.js:

  • ./app/components/charts/baseChart.tsx → Total Size: 106.29kB

Comment on lines 97 to 108
<ReleaseSeries
start={start}
end={end}
queryExtra={undefined}
period={period}
utc={utc}
projects={projects}
environments={environments}
>
{({releases}) => {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need releases to show on the "mini" charts instead of only fullscreen. This sucks because it will make a request for releases per widget.

TODO: Change to react-query + hooks

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This sucks because it will make a request for releases per widget

Will it? I updated ReleaseSeries a while back to share data between every instance of the component, so they shouldn't be making any extra requests. If that's not working, I can fix it! The hook is better though

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I could have been misinterpreting the requests I was seeing

@billyvg billyvg force-pushed the feat-ui-release-bubbles branch from 04f60f2 to eeb62f9 Compare February 28, 2025 15:39
Base automatically changed from feat-ui-add-unused-release-drawer to master February 28, 2025 18:49
@billyvg billyvg force-pushed the feat-ui-release-bubbles branch from eeb62f9 to a39025f Compare February 28, 2025 18:53
@billyvg billyvg marked this pull request as ready for review February 28, 2025 20:30
@billyvg billyvg requested review from a team as code owners February 28, 2025 20:30
@billyvg billyvg requested a review from gggritso February 28, 2025 20:30
@billyvg
Copy link
Member Author

billyvg commented Feb 28, 2025

apologies ahead of time @gggritso

billyvg added 24 commits March 3, 2025 15:29
Replace the old `<ReleaseSeries>` renderer and use a simple hook to fetch Release Stats

ref #85779
Adds components needed to render a Release Drawer via the global drawer. It current is not used, but will be as part of #85775.

Refs #85779
Refs #85775
This is a draft PR to ensure we can manipulate echarts the way we want to.

What we are trying to do instead of drawing a single line per release is to group releases up into time buckets and show them as a bubble below the main chart. This demonstrates the ability to do this as well as:

* shading the relevant area on chart when hovering over bubble
* highlighting relevant bubble when moving mouse around the chart
* click handler for the bubble
* tooltips function as expected between release bubbles and main chart
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants