Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bids 2567/stats page for validators without index #2625

Merged
merged 7 commits into from
Oct 24, 2023

Conversation

D13ce
Copy link
Contributor

@D13ce D13ce commented Oct 19, 2023

This PR mainly hides the stats tables on the validator page whenever a validator that is still only "deposited" or "pending" is shown.

Furthermore it improves and unifies the error logging within validator.go, removes a sentence that makes so sense on validatornotfound.html and adds periods to all "not found"-pages.

Copy link
Collaborator

@Eisei24 Eisei24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm for the issue the BIDS was about but please have a look at my comments for the improved error handling.

handlers/validator.go Outdated Show resolved Hide resolved
handlers/validator.go Outdated Show resolved Hide resolved
handlers/validator.go Show resolved Hide resolved
Copy link
Collaborator

@Eisei24 Eisei24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@D13ce D13ce merged commit 3d735ae into master Oct 24, 2023
3 checks passed
@D13ce D13ce deleted the BIDS-2567/StatsPageForValidatorsWithoutIndex branch October 24, 2023 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants