Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bids 2567/stats page for validators without index #2625

Merged
merged 7 commits into from
Oct 24, 2023
Merged

Bids 2567/stats page for validators without index #2625

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
5652e25
(BIDS-2567) Improve error handling and remove out-commented code
D13ce Oct 19, 2023
f11769b
(BIDS-2567) Improve and unify error logs in validator.go
D13ce Oct 19, 2023
3efb360
(BIDS-2567) Hide stats button for deposited/pending validators
D13ce Oct 19, 2023
92f4480
(BIDS-2567) Add period to most "could not find" pages
D13ce Oct 19, 2023
e917bc4
(BIDS-2567) Add period to tx not found page
D13ce Oct 19, 2023
ce2430c
(BIDS-2567) Remove line about mempool from validtor not found page
D13ce Oct 19, 2023
f7e29e1
(BIDS-2567) Implement requested changes from code review
D13ce Oct 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
276 changes: 173 additions & 103 deletions handlers/validator.go
View file
Open in desktop
Eisei24 marked this conversation as resolved.
Show resolved Hide resolved

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion templates/404notfound.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
<div class="container">
<div style="padding-top: 2rem;" class="row justify-content-between align-items-center">
<div class="col-md-6 mb-5">
<h2 style="font-size:1.8rem;">Sorry, the page you are looking for could not be found</h2>
<h2 style="font-size:1.8rem;">Sorry, the page you are looking for could not be found.</h2>
</div>
<div class="col-md-5 p-3">
{{ template "relax_svg" }}
Expand Down
2 changes: 1 addition & 1 deletion templates/dashboardnotfound.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
{{ define "content" }}
{{ with .Data }}
<div class="container mt-2">
<h1 class="mt-4 text-center">Sorry but we could not find the dashboard you are looking for</h1>
<h1 class="mt-4 text-center">Sorry but we could not find the dashboard you are looking for.</h1>
</div>
{{ end }}
{{ end }}
2 changes: 1 addition & 1 deletion templates/epochnotfound.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ <h1 class="h4 mb-1 mb-md-0"><i class="fas fa-history mr-2"></i>Epoch not found</
</div>
<div class="card">
<div class="card-body">
<div class="d-1">Sorry but we could not find the epoch you are looking for</div>
<div class="d-1">Sorry but we could not find the epoch you are looking for.</div>
</div>
</div>
</div>
Expand Down
2 changes: 1 addition & 1 deletion templates/eth1txnotfound.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ <h1 class="h4 mb-1 mb-md-0"><i class="fas fa-history mr-2"></i>Tx not found</h1>
</div>
<div class="card">
<div class="card-body">
<div class="d-1">Sorry but we could not find the tx you are looking for</div>
<div class="d-1">Sorry but we could not find the tx you are looking for.</div>
</div>
</div>
</div>
Expand Down
2 changes: 1 addition & 1 deletion templates/slotnotfound.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ <h1 class="h4 mb-1 mb-md-0"><i class="fas fa-cube mr-2"></i>{{ if eq . "block" }
</div>
<div class="card">
<div class="card-body">
<div class="d-1">Sorry but we could not find the {{ if eq . "block" }}block{{ else }}slot{{ end }} you are looking for</div>
<div class="d-1">Sorry but we could not find the {{ if eq . "block" }}block{{ else }}slot{{ end }} you are looking for.</div>
</div>
</div>
</div>
Expand Down
12 changes: 7 additions & 5 deletions templates/validator/heading.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,11 +36,13 @@ <h1 class="h4 mb-1 mb-md-0 d-flex align-items-center">
</button>
</span>
{{ end }}
<span class="mx-1" data-toggle="tooltip" title="View daily statistics">
<a class="btn btn-dark text-white btn-sm" href="/validator/{{ .Index }}/stats">
<i class="fas fa-table"></i>
</a>
</span>
{{ if (and (ne .Status "deposited") (ne .Status "deposited_invalid") (ne .Status "pending")) }}
<span class="mx-1" data-toggle="tooltip" title="View daily statistics">
<a class="btn btn-dark text-white btn-sm" href="/validator/{{ .Index }}/stats">
<i class="fas fa-table"></i>
</a>
</span>
{{ end }}
</h1>
</div>
<nav aria-label="breadcrumb">
Expand Down
1 change: 0 additions & 1 deletion templates/validator/validatornotfound.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@ <h1 class="h4 mb-1 mb-md-0"><i class="fas fa-male mr-2"></i>Validator not found<
<div class="card">
<div class="card-body">
<div class="d-1">Sorry, but we could not find the validator you are looking for.</div>
<div class="d-1">Stay calm, depending on the gas price of the transaction, <a href="https://kb.beaconcha.in/ethereum-2.0-and-depositing-process">it may still be in the mempool.</a></div>
</div>
</div>
</div>
Expand Down
Loading