chore(eslint)!: migrate all eslint configs to v9 #974
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: This removes v8 from being supported and moves to flat config
BREAKING CHANGE: This removes eslint@v8 from support and moves to flat config
BREAKING CHANGE: This removes eslint@v8 from support and moves to flat config
BREAKING CHANGE: This removes eslint@v8 from support and moves to flat config
3rd-Eden
reviewed
Dec 25, 2024
.changeset/blue-rats-notice.md
Outdated
|
|
||
| chore(eslint)!: migrate all eslint configs to eslint@v9 | ||
|
|
||
| BREAKING CHANGE: removes v8 support and transistions configs to flat config |
There was a problem hiding this comment.
Might want to explicitly call out that these are now type:module instead of the previous cjs format.
3rd-Eden
approved these changes
Dec 25, 2024
There's 3 (normie), 9 (react) projects still depending on this package internally, but I agree, that it's not enough to warrent keeping this configuration around. |
cburton-godaddy
approved these changes
Jan 6, 2025
kbader-godaddy
approved these changes
Jan 6, 2025
jsanthosh-godaddy
approved these changes
Jan 6, 2025
agerard-godaddy
approved these changes
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR upgrades all eslint configs to use v9. I know that in eslint >= 8.23 flat config is supported however, feasibly I do not want to make these config semi backwards. Better to do the breaking change now and just keep a v8 branch for patch/bug updates. I've also removed the
flowbased configs. I know Flow is still around and utilized but we no longer support its use internally at GoDaddy. If there are hard opinions to this I do not mind bringing them back in this PR and migrating them to v9. I've also remove the CLI portion of these libraries as we should only be using theeslintbinary directly.The biggest question here is should be using all the custom rules we have established here or should we be leveraging the industry standards. A lot of our rules are outdated and often times conflicted with a lot of
recommendedconfigs and plugins. IMHO we should probably lean that way and allow the consumer to decide if they want to modify the rules they want to have. The config should mostly provide the additional configs and plugins (such as the react, mocha, node, ect.) doing this keep their configs small but still allows for flexibility.Changeset
Test Plan
These have been tested locally to make