Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(eslint)!: migrate all eslint configs to v9 #974

Merged
merged 10 commits into from
Jan 17, 2025
10 changes: 10 additions & 0 deletions .changeset/blue-rats-notice.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
---
"eslint-config-godaddy-react-typescript": major
"eslint-config-godaddy-typescript": major
"eslint-config-godaddy-react": major
"eslint-config-godaddy": major
---

chore(eslint)!: migrate all eslint configs to eslint@v9

BREAKING CHANGE: removes v8 support and transistions configs to flat config
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might want to explicitly call out that these are now type:module instead of the previous cjs format.

6 changes: 4 additions & 2 deletions .eslintrc.js → eslint.config.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
module.exports = {
extends: './packages/eslint-config-godaddy/index.js',
import gdConfig from "./packages/eslint-config-godaddy/index.js";

export default {
...gdConfig,
rules: {
//
// This is used for both ES5 and ES6 config filesso we simply
Expand Down
3,011 changes: 1,685 additions & 1,326 deletions package-lock.json

Large diffs are not rendered by default.

17 changes: 11 additions & 6 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
"version": "6.0.0",
"private": true,
"description": "The approach to JavaScript at GoDaddy. We think it's pretty decent.",
"type": "module",
"engines": {
"node": ">=22",
"npm": ">=10"
Expand Down Expand Up @@ -47,16 +48,20 @@
"godaddy-js-style-eslint": "./bin/eslint"
},
"devDependencies": {
"@changesets/cli": "^2.27.9",
"eslint": "^8.57.1",
"eslint-plugin-json": "^3.1.0",
"@changesets/cli": "^2.27.11",
"@eslint/eslintrc": "^3.2.0",
"@eslint/js": "^9.17.0",
"@typescript-eslint/eslint-plugin": "^8.18.1",
"@typescript-eslint/parser": "^8.18.1",
"eslint": "^9.17.0",
"eslint-plugin-json": "^4.0.1",
"eslint-plugin-jsx-a11y": "^6.10.2",
"eslint-plugin-mocha": "^10.5.0",
"eslint-plugin-react": "^7.37.2",
"react": "^17.0.2",
"rimraf": "^3.0.2",
"react": "^19.0.0",
"rimraf": "^6.0.1",
"turbo": "^1.13.4",
"typescript": "^4.9.5"
"typescript": "^5.7.2"
},
"workspaces": [
"packages/*"
Expand Down
3 changes: 0 additions & 3 deletions packages/eslint-config-godaddy-flow/.eslintrc

This file was deleted.

2 changes: 0 additions & 2 deletions packages/eslint-config-godaddy-flow/.npmignore

This file was deleted.

41 changes: 0 additions & 41 deletions packages/eslint-config-godaddy-flow/CHANGELOG.md

This file was deleted.

55 changes: 0 additions & 55 deletions packages/eslint-config-godaddy-flow/README.md

This file was deleted.

4 changes: 0 additions & 4 deletions packages/eslint-config-godaddy-flow/bin/eslint-godaddy-flow

This file was deleted.

17 changes: 0 additions & 17 deletions packages/eslint-config-godaddy-flow/extends.js

This file was deleted.

24 changes: 0 additions & 24 deletions packages/eslint-config-godaddy-flow/index.js

This file was deleted.

43 changes: 0 additions & 43 deletions packages/eslint-config-godaddy-flow/package.json

This file was deleted.

3 changes: 0 additions & 3 deletions packages/eslint-config-godaddy-react-flow/.eslintrc

This file was deleted.

2 changes: 0 additions & 2 deletions packages/eslint-config-godaddy-react-flow/.npmignore

This file was deleted.

41 changes: 0 additions & 41 deletions packages/eslint-config-godaddy-react-flow/CHANGELOG.md

This file was deleted.

55 changes: 0 additions & 55 deletions packages/eslint-config-godaddy-react-flow/README.md

This file was deleted.

This file was deleted.

17 changes: 0 additions & 17 deletions packages/eslint-config-godaddy-react-flow/extends.js

This file was deleted.

Loading
Loading