-
Notifications
You must be signed in to change notification settings - Fork 104
Black screen on showing camera frames #69
base: master
Are you sure you want to change the base?
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for sending a PR. I think this PR is not finished or correct, right?
@@ -513,7 +513,7 @@ - (void)_updateCapturedImageTexturesWithFrame:(ARFrame *)frame { | |||
|
|||
const size_t width = CVPixelBufferGetWidthOfPlane(pixelBuffer, planeIndex); | |||
const size_t height = CVPixelBufferGetHeightOfPlane(pixelBuffer, planeIndex); | |||
|
|||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess that this is not the change you were intending to submit. Am I right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not really. That's weird. The lines 66 and 518 were changed.
Maybe it's because I tried one PR before but had to undo it.
the method CVMetalTextureCacheCreateTextureFromImage was generating the error -6661 for every frame because it was expecting the _capturedImageTextureCache variable to be CVMetalTextureCacheRef rather than CVOpenGLESTextureCacheRef.
This change provides the correction to make the camera work again.