Skip to content
This repository has been archived by the owner on Nov 15, 2022. It is now read-only.

Black screen on showing camera frames #69

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

diegomeire
Copy link

the method CVMetalTextureCacheCreateTextureFromImage was generating the error -6661 for every frame because it was expecting the _capturedImageTextureCache variable to be CVMetalTextureCacheRef rather than CVOpenGLESTextureCacheRef.

This change provides the correction to make the camera work again.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

Copy link
Contributor

@judax judax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for sending a PR. I think this PR is not finished or correct, right?

@@ -513,7 +513,7 @@ - (void)_updateCapturedImageTexturesWithFrame:(ARFrame *)frame {

const size_t width = CVPixelBufferGetWidthOfPlane(pixelBuffer, planeIndex);
const size_t height = CVPixelBufferGetHeightOfPlane(pixelBuffer, planeIndex);

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess that this is not the change you were intending to submit. Am I right?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not really. That's weird. The lines 66 and 518 were changed.
Maybe it's because I tried one PR before but had to undo it.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants