Skip to content
This repository has been archived by the owner on Nov 15, 2022. It is now read-only.

Black screen on showing camera frames #69

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Black screen on showing camera frames #69

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2f9a3a0
Renderer CVMetalTextureCacheCreateTextureFromImage
Nov 26, 2018
ba5d834
Revert "Renderer CVMetalTextureCacheCreateTextureFromImage"
Nov 26, 2018
65436b4
Renderer
Nov 26, 2018
2a7cdb5
Renderer
Nov 26, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion WebARonARKit/WebARonARKit/Renderer.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -513,7 +513,7 @@ - (void)_updateCapturedImageTexturesWithFrame:(ARFrame *)frame {

const size_t width = CVPixelBufferGetWidthOfPlane(pixelBuffer, planeIndex);
const size_t height = CVPixelBufferGetHeightOfPlane(pixelBuffer, planeIndex);

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess that this is not the change you were intending to submit. Am I right?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not really. That's weird. The lines 66 and 518 were changed.
Maybe it's because I tried one PR before but had to undo it.

CVMetalTextureRef texture = NULL;
CVReturn status = CVMetalTextureCacheCreateTextureFromImage(
NULL, _capturedImageTextureCache, pixelBuffer, NULL, pixelFormat, width, height, planeIndex,
Expand Down