Fix MimirAutoscalerNotActive alert #10564
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Marco Pracucci <[email protected]>
pracucci
commented
Feb 3, 2025
| @@ -53,8 +53,6 @@ | |||
| * [BUGFIX] PromQL: Fix <aggr_over_time> functions with histograms https://github.com/prometheus/prometheus/pull/15711 #10400 | |||
| * [BUGFIX] MQE: Fix <aggr_over_time> functions with histograms #10400 | |||
| * [BUGFIX] Distributor: return HTTP status 415 Unsupported Media Type instead of 200 Success for Remote Write 2.0 until we support it. #10423 | |||
| * [BUGFIX] Query-frontend: Add flag `-query-frontend.prom2-range-compat` and corresponding YAML to rewrite queries with ranges that worked in Prometheus 2 but are invalid in Prometheus 3. #10445 #10461 | |||
| * [BUGFIX] mixin: fix autoscaling panels. #10473 | |||
There was a problem hiding this comment.
Note to reviewers: moved below.
pracucci
commented
Feb 3, 2025
| @@ -53,8 +53,6 @@ | |||
| * [BUGFIX] PromQL: Fix <aggr_over_time> functions with histograms https://github.com/prometheus/prometheus/pull/15711 #10400 | |||
| * [BUGFIX] MQE: Fix <aggr_over_time> functions with histograms #10400 | |||
| * [BUGFIX] Distributor: return HTTP status 415 Unsupported Media Type instead of 200 Success for Remote Write 2.0 until we support it. #10423 | |||
| * [BUGFIX] Query-frontend: Add flag `-query-frontend.prom2-range-compat` and corresponding YAML to rewrite queries with ranges that worked in Prometheus 2 but are invalid in Prometheus 3. #10445 #10461 | |||
There was a problem hiding this comment.
Note to reviewers: I accidentally duplicated this entry in #10473.
dimitarvdimitrov
approved these changes
Feb 3, 2025
No problem! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
While reviewing #10473 I noticed that the MimirAutoscalerNotActive alert is not working because of the missing
metricaggregation. This PR fixes it.To manually test it I've flipped the
{condition="ScalingActive",status="false"}to{condition="ScalingActive",status="true"}, so that all HPAs match.Before (no matching series):
After (231 matching series):
Which issue(s) this PR fixes or relates to
N/A
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX].about-versioning.mdupdated with experimental features.