Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix MimirAutoscalerNotActive alert #10564

Merged
merged 1 commit into from
Feb 3, 2025
Merged

Fix MimirAutoscalerNotActive alert #10564

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,8 +53,6 @@
* [BUGFIX] PromQL: Fix <aggr_over_time> functions with histograms https://github.com/prometheus/prometheus/pull/15711 #10400
* [BUGFIX] MQE: Fix <aggr_over_time> functions with histograms #10400
* [BUGFIX] Distributor: return HTTP status 415 Unsupported Media Type instead of 200 Success for Remote Write 2.0 until we support it. #10423
* [BUGFIX] Query-frontend: Add flag `-query-frontend.prom2-range-compat` and corresponding YAML to rewrite queries with ranges that worked in Prometheus 2 but are invalid in Prometheus 3. #10445 #10461
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note to reviewers: I accidentally duplicated this entry in #10473.

* [BUGFIX] mixin: fix autoscaling panels. #10473
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note to reviewers: moved below.

* [BUGFIX] Query-frontend: Add flag `-query-frontend.prom2-range-compat` and corresponding YAML to rewrite queries with ranges that worked in Prometheus 2 but are invalid in Prometheus 3. #10445 #10461 #10502
* [BUGFIX] Distributor: Fix edge case at the HA-tracker with memberlist as KVStore, where when a replica in the KVStore is marked as deleted but not yet removed, it fails to update the KVStore. #10443
* [BUGFIX] Distributor: Fix panics in `DurationWithJitter` util functions when computed variance is zero. #10507
Expand All @@ -65,6 +63,8 @@
* [BUGFIX] Dashboards: fix how we switch between classic and native histograms. #10018
* [BUGFIX] Alerts: Ignore cache errors performing `delete` operations since these are expected to fail when keys don't exist. #10287
* [BUGFIX] Dashboards: fix "Mimir / Rollout Progress" latency comparison when gateway is enabled. #10495
* [BUGFIX] Dashboards: fix autoscaling panels when Mimir is deployed using Helm. #10473
* [BUGFIX] Alerts: fix `MimirAutoscalerNotActive` alert. #10564

### Jsonnet

Expand Down
2 changes: 1 addition & 1 deletion ...amonitoring-values-generated/mimir-distributed/templates/metamonitoring/mixin-alerts.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -992,7 +992,7 @@ spec:
# Add "metric" label.
+ on(cluster, namespace, horizontalpodautoscaler) group_right
# Using `max by ()` so that series churn doesn't break the promQL join
max by (cluster, namespace, horizontalpodautoscaler) (
max by (cluster, namespace, horizontalpodautoscaler, metric) (
label_replace(kube_horizontalpodautoscaler_spec_target_metric*0, "metric", "$1", "metric_name", "(.+)")
)
> 0),
Expand Down
2 changes: 1 addition & 1 deletion operations/mimir-mixin-compiled-baremetal/alerts.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -966,7 +966,7 @@ groups:
# Add "metric" label.
+ on(cluster, namespace, horizontalpodautoscaler) group_right
# Using `max by ()` so that series churn doesn't break the promQL join
max by (cluster, namespace, horizontalpodautoscaler) (
max by (cluster, namespace, horizontalpodautoscaler, metric) (
label_replace(kube_horizontalpodautoscaler_spec_target_metric*0, "metric", "$1", "metric_name", "(.+)")
)
> 0),
Expand Down
2 changes: 1 addition & 1 deletion operations/mimir-mixin-compiled/alerts.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -980,7 +980,7 @@ groups:
# Add "metric" label.
+ on(cluster, namespace, horizontalpodautoscaler) group_right
# Using `max by ()` so that series churn doesn't break the promQL join
max by (cluster, namespace, horizontalpodautoscaler) (
max by (cluster, namespace, horizontalpodautoscaler, metric) (
label_replace(kube_horizontalpodautoscaler_spec_target_metric*0, "metric", "$1", "metric_name", "(.+)")
)
> 0),
Expand Down
2 changes: 1 addition & 1 deletion operations/mimir-mixin/alerts/autoscaling.libsonnet
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
# Add "metric" label.
+ on(%(aggregation_labels)s, horizontalpodautoscaler) group_right
# Using `max by ()` so that series churn doesn't break the promQL join
max by (%(aggregation_labels)s, horizontalpodautoscaler) (
max by (%(aggregation_labels)s, horizontalpodautoscaler, metric) (
label_replace(kube_horizontalpodautoscaler_spec_target_metric*0, "metric", "$1", "metric_name", "(.+)")
)
> 0),
Expand Down