Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add linkcheck option to ignore httpredirect warnings #2024

Merged
merged 1 commit into from
Feb 13, 2025

Conversation

ppcano
Copy link
Contributor

@ppcano ppcano commented Feb 10, 2025

The make linkcheck command in the unit tests / docs CI job was failing because some URLs were redirected:

That's it. 186 links in 188 URLs checked. 2 warnings found. 0 errors found.
Stopped checking at 2025-02-10 11:10:04+000 (22 seconds)
make: *** [linkcheck] Error 1


Exit Code: 2

Since redirects shouldn’t be considered failures, this PR adds the ignorewarnings=http-redirected option to suppress httpredirect failures.

With this change, the make linkcheck output now displays:

That's it. 186 links in 188 URLs checked. 0 warnings found. 0 errors found.
Stopped checking at 2025-02-10 11:11:12+000 (28 seconds)

Exit Code: 0

@ppcano ppcano requested a review from a team as a code owner February 10, 2025 11:25
Copy link

In order to lower resource usage and have a faster runtime, PRs will not run Cloud tests automatically.
To do so, a Grafana Labs employee must trigger the cloud acceptance tests workflow manually.

@brojd brojd merged commit 39ecb81 into main Feb 13, 2025
26 checks passed
@brojd brojd deleted the pepe/linkcheck-ignore-redirect-warnings branch February 13, 2025 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants