Add timeout to WaitForNavigation

grafana · Aug 11, 2022 · 1e9fda0 · 1e9fda0
1 parent b27f684
commit 1e9fda0
Showing 1 changed file with 5 additions and 1 deletion.
diff --git a/tests/frame_manager_test.go b/tests/frame_manager_test.go
@@ -112,9 +112,13 @@ func TestWaitForFrameNavigation(t *testing.T) {
 		Timeout:   common.DefaultTimeout,
 	})))
 
+	var timeout time.Duration = 5000 // interpreted as ms
+
 	var wfnPromise, cPromise *goja.Promise
 	err := tb.await(func() error {
-		wfnPromise = p.WaitForNavigation(nil)
+		wfnPromise = p.WaitForNavigation(tb.toGojaValue(&common.FrameWaitForNavigationOptions{
+			Timeout: timeout, // interpreted as ms
+		}))
 		cPromise = p.Click(`a`, nil)
 
 		assert.Equal(t, goja.PromiseStatePending, wfnPromise.State())