-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade Guardian services to Panda v7 - support key rotation #160
Comments
This upgrades Panda from v5 to v7, allowing us to use key rotation as introduced with guardian/pan-domain-authentication#150. See also guardian/pan-domain-authentication#160.
This upgrades Panda from v5 to v7, allowing us to use key rotation as introduced with guardian/pan-domain-authentication#150. See also guardian/pan-domain-authentication#160.
This upgrades Panda from v5 to v7, allowing us to use key rotation as introduced with guardian/pan-domain-authentication#150. See also guardian/pan-domain-authentication#160.
Now that guardian/workflow-frontend#489 has been merged, workflow-frontend has been successfully upgraded to v7. (I can't edit this issue to check the item for it above.) |
I feel like 'workflow-and-collaboration' are the natural owners of Panda, but I know that isn't settled yet.. in the meantime, I've given 'workflow-and-collaboration' write access to this repo (with the 'maintain' role) and so hopefully you should be able to check the checkmark now...! |
I can indeed, thanks for the change :) |
Note that all the systems in the minimum subset have now been updated to panda v7. |
Guardian services using Panda
ELK logs for Settings.Refresher
Migration pathway
Best to jump straight to Panda v7, without stopping off on v5/v6 on the way, as the location of the private/public key fields has changed and is eventually removed in favour of the
verification
/signingAndVerification
fields - so avoid multiple changes and jump straight to using those.Necessary changes to code using Panda
java.security
classes in preference to string-wrappers #147 removed the oldPublicKey
&PrivateKey
classes in ourcom.gu.pandomainauth
package, in favour of using the existingjava.security
classes. To create instances of those classes, we can use theSettingsReader.{privateKeyFor, publicKeyFor}
methods.PanDomainAuthSettingsRefresher
instances, makepanDomainSettings
aval
#155 requirespanDomainSettings
is aval
, not adef
S3BucketLoader
abstraction, which simplifies constructing aPanDomainAuthSettingsRefresher
and means that Panda is no longer tied to AWS SDK v1. Examples: tagmanager, login.gutoolsCookieUtils.generateCookieData()
method now communicates errors withCookieResult
values containingCookieIntegrityFailure
, rather than exceptions.settings.signingKeyPair
). Instead, usesettings.signingAndVerification
orpublicSettings.verification
. Note also thatpublicSettings.publicKey
was previously optional, andpublicSettings.verification
is not.Services using Panda
Content Production
Trello cards:
PRs:
Newsroom Resilience
WebX
MSS
Investigations & Reporting
Minimum subset of systems we'd want to have on Panda v7 before performing a rotation
& newswires(update: newswires is not in production use yet so it shouldn't block rotation work)The text was updated successfully, but these errors were encountered: