Update panda to v7 #489
Merged
Update panda to v7 #489
+15
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
actions-riff-raff v4 comments on the PR with some useful links for deploying, so I’d like to update to it. I’ve followed the changes described in [the readme](https://github.com/guardian/actions-riff-raff/blob/6ddd4acd261c4265995908a68f0592ad1604b56e/README.md#L267-L286) for migrating from v3 to v4, and copied the necessary changes for v3 as well (to do with commenting on the PR).
prout-bot
added
Pending-on-WORKFLOW_PROD
Seen-on-WORKFLOW_PROD
and removed
Pending-on-WORKFLOW_PROD
labels
|
Seen on WORKFLOW_PROD (merged by @emdash-ie 6 minutes and 24 seconds ago) Please check your changes! |
|
I've checked on workfow in PROD post-merge and I'm still able (and required) to log in. I also looked at the logs and didn't see anything very concerning: a spike in WARN/ERROR logs right at deployment time, but that has since gone away. |
Open
8 tasks
emdash-ie
commented
Jan 30, 2025
emdash-ie
commented
Jan 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
This PR updates the dependencies on panda to 7.0.0, following the instructions in guardian/pan-domain-authentication#160.
I also took the opportunity to update the use of actions-riff-raff to v4 in 9ef3dea.
How to test
To test, I deployed this PR to CODE, and then confirmed that I can still visit https://workflow.code.dev-gutools.co.uk/dashboard. I also tried clearing my cookies and watching the network tab to make sure the oauth redirects happened and worked, which they did. Finally, I tried accessing the page from a private tab (where I wasn’t signed into my google account) and saw a prompt from google to log in.
Is there anything else I should check?