remove avatar URL discrepancy detection (since it's arguably more wasteful than just updating the DB records) #300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eful than just updating the DB records
davidfurey
approved these changes
Dec 6, 2023
|
Seen on PROD (merged by @twrichards 5 minutes and 26 seconds ago) Please check your changes! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#193 added some logic for detecting when Google People API returned a different avatar URL than last time but in fact the image content was the same. This seems to happen all the time now, so on reflection requesting the bytes of the image twice for each user seems more wasteful than just updating the records in the DB when the avatar URL changes.