Sponsorship packages

[davidfurey]

What does this change?

Creates a new sponsorship attribute called sponsorshipPackage. This is to allow the US Ads team to sell sponsorships under the ‘Advertising partner’ or ‘Exclusive advertising partner’ labels. These labels will never be applied to Foundation funded journalism.

An update to our externally facing content funding guidelines will be published before this change is used.

How to test

Cannot be tested until tags-thrift-schema PR is released. See guardian/tags-thrift-schema#43

• Deploy to CODE.
• ensure you have permission
  
• Attempt to create a new sponsored tag
• See that you can set the sponsorshipPackage to default, advertising partner or exclusive advertising partner
• See that once you have created the tag you can edit this field but cannot edit the sponsorship type
• Attempt to edit a pre-existing sponsored tag
• See that its sponsorshipPackage is set to the default value initially

How can we measure success?

US ads team are able to create new sponsorships that meet their requirements.

Have we considered potential risks?

Existing tags will continue to have no value for this field until they are first edited. This is captured as an Option value in Scala and an optional field in thrift.

Images

Creating a sponsored tag

Before

After

Editing a sponsored tag

Before

After

Accessibility

• Tested with screen reader
• Navigable with keyboard
• Colour contrast passed
• The change doesn't use only colour to convey meaning

[twrichards]

tested in CODE - all working nicely AFAICT

Code LGTM and I learnt that return false from a component (as you have done) is better than return null when you don't want the component to render anything.

[twrichards]

if you want it to render nothing, I think returning null is better to avoid false being printed to the screen

Suggested change

	return false;
	return null;

Well, TIL https://medium.com/@davidkelley87/stop-using-return-null-in-react-a2ebf08fc9cd

[davidfurey]

So I should stick with return false? Most of this was copy+pasted from SponsorshipPackageType.react.js