Add optional sponsorship package field #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 16, 2024
twrichards
approved these changes
Feb 19, 2024
There was a problem hiding this comment.
LGTM
Will test guardian/tagmanager#508 once you've merged/released (I stopped short of merging this on your behalf just in case)
|
I would suggest testing the other PR using publishLocal. But maybe there is no downside in merging this one? |
|
Since the library release is still manual for this I've opened #44 to automate. Perhaps in the meantime you can review the other PR using publishLocal? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Adds a new field for sponsorship package. More information in guardian/tagmanager#508