Fix sprite loading #174
Merged
Fix sprite loading #174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes rsync issue and prevents files from disappearing: rsync warning: some files vanished before they could be transferred (code 24)
Fixed rsync warning from copy source code to docker volume
Wolf3s
approved these changes
Jan 5, 2024
This was referenced Jan 19, 2024
Merged
optimization
GDQR
commented
Jan 25, 2024
Comment on lines
-276
to
-279
| for (int i = numPallete; i < 16; i++) { | ||
| memset(&clut[i], 0, sizeof(clut[i])); | ||
| } | ||
|
|
There was a problem hiding this comment.
unnecessary function, this function already does it before:
memset(result->clut, 0, getTextureSize(8, 2, bpp32));
|
Thank you for contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
change core width and clut width.
without this the width is the same if is below 64 and an error occurs with 32x"64 or more" images.
renderer_core_2d.cpp use
packet2_utils_gs_add_texbuff_clut(packet, texBuffers.core, clutBuffer);and this function need the width be 64 or more.