Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: adds tests that verify IHRC904 claimAirdrops targeted to an EOA are functional when called by a contract #1200

Merged
merged 10 commits into from
Feb 4, 2025
Merged

feat: adds tests that verify IHRC904 claimAirdrops targeted to an EOA are functional when called by a contract #1200

merged 10 commits into from
Feb 4, 2025

Conversation

simzzz
Copy link
Contributor

@simzzz simzzz commented Jan 21, 2025 •
edited
Loading

Description:
This PR adds tests that verify IHRC904 claimAirdrops targeted to an EOA are functional when called by a contract as per the design doc

Related issue(s):

Fixes #1188

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@quiet-node quiet-node added the enhancement New feature or request label Jan 21, 2025
@quiet-node quiet-node added this to the 0.12.0 milestone Jan 21, 2025
@simzzz simzzz requested a review from konstantinabl January 29, 2025 09:04
quiet-node
quiet-node requested changes Jan 29, 2025
View reviewed changes
Copy link
Member

@quiet-node quiet-node left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as other PRs let's clean up and reuse code where possible.

Thanks for the great work as always!

test/constants.js Outdated Show resolved Hide resolved
test/system-contracts/hedera-token-service/hrc-904/ClaimAirdropContract.js Outdated Show resolved Hide resolved
test/system-contracts/hedera-token-service/hrc-904/ClaimAirdropContract.js Show resolved Hide resolved
@simzzz simzzz requested a review from quiet-node January 30, 2025 15:12
quiet-node
quiet-node previously approved these changes Jan 30, 2025
View reviewed changes
Copy link
Member

@quiet-node quiet-node left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the great work!

konstantinabl
konstantinabl previously approved these changes Feb 4, 2025
View reviewed changes
@simzzz simzzz dismissed stale reviews from konstantinabl and quiet-node via d839c47 February 4, 2025 13:56
quiet-node
quiet-node approved these changes Feb 4, 2025
View reviewed changes
Copy link
Member

@quiet-node quiet-node left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the great work as always!

@simzzz simzzz merged commit 7f00646 into hashgraph:main Feb 4, 2025
33 checks passed
@simzzz simzzz deleted the 1188-claim-airdrop-coverage branch February 4, 2025 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@quiet-node quiet-node quiet-node approved these changes

@konstantinabl konstantinabl konstantinabl left review comments

@georgi-l95 georgi-l95 Awaiting requested review from georgi-l95 georgi-l95 is a code owner

@Ivo-Yankov Ivo-Yankov Awaiting requested review from Ivo-Yankov Ivo-Yankov is a code owner

@natanasow natanasow Awaiting requested review from natanasow natanasow is a code owner

@yiliev0 yiliev0 Awaiting requested review from yiliev0 yiliev0 is a code owner

Assignees

@simzzz simzzz

Labels
enhancement New feature or request
Projects
None yet
Milestone
0.12.0
Development

Successfully merging this pull request may close these issues.

Add tests that verify IHRC904 claimAirdrops targeted to an EOA are functional when called by a contract
3 participants
@simzzz @konstantinabl @quiet-node