Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adds tests that verify IHRC904 claimAirdrops targeted to an EOA are functional when called by a contract #1200

Merged
merged 10 commits into from
Feb 4, 2025
Merged

feat: adds tests that verify IHRC904 claimAirdrops targeted to an EOA are functional when called by a contract #1200

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
c583cf0
feat: added test coverage for ClaimAirdrop.sol
simzzz Jan 21, 2025
4a80c4e
skipped tests temporarily
simzzz Jan 24, 2025
c6f79f3
Merge branch 'main' into 1188-claim-airdrop-coverage
simzzz Jan 27, 2025
4884642
exported magic string as constant + more clarity comments for skipped…
simzzz Jan 29, 2025
d157da5
linked issue to TODO comments
simzzz Jan 29, 2025
287179f
requested changes from review
simzzz Jan 30, 2025
98b8b55
exported createPendingAirdrops to utils class
simzzz Jan 30, 2025
d839c47
Merge branch 'main' into 1188-claim-airdrop-coverage
simzzz Feb 4, 2025
aeecae4
Merge branch 'main' into 1188-claim-airdrop-coverage
simzzz Feb 4, 2025
ba23cbc
fix conflicts
simzzz Feb 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions ...system-contracts/hedera-token-service/examples/hrc-904/ClaimAirdrop.sol/ClaimAirdrop.json
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion ...system-contracts/hedera-token-service/examples/hrc-904/ClaimAirdrop.sol/ClaimAirdrop.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@
"type": "int64[]"
}
],
"name": "claimAirdrops",
"name": "claimMultipleAirdrops",
"outputs": [
{
"internalType": "int64",
Expand Down
2 changes: 1 addition & 1 deletion contracts/system-contracts/hedera-token-service/examples/hrc-904/ClaimAirdrop.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ contract ClaimAirdrop is HederaTokenService {
// @param tokens Array of token addresses for the pending airdrops
// @param serials Array of serial numbers for NFT airdrops (use 0 for fungible tokens)
// @return responseCode The response code from the batch claim operation (22 = success)
function claimAirdrops(address[] memory senders, address[] memory receivers, address[] memory tokens, int64[] memory serials) public returns (int64 responseCode) {
function claimMultipleAirdrops(address[] memory senders, address[] memory receivers, address[] memory tokens, int64[] memory serials) public returns (int64 responseCode) {
uint length = senders.length;
IHederaTokenService.PendingAirdrop[] memory pendingAirdrops = new IHederaTokenService.PendingAirdrop[](length);
for (uint i = 0; i < length; i++) {
Expand Down
6 changes: 6 additions & 0 deletions test/constants.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -204,12 +204,15 @@ const Contract = {
CancunOpcodes: 'CancunOpcodes',
KZGPointEvaluation: 'KZGPointEvaluation',
StateRegistry: 'StateRegistry',
Airdrop: 'Airdrop',
ClaimAirdrop: 'ClaimAirdrop',
AliasAccountUtility: 'AliasAccountUtility',
};

const CALL_EXCEPTION = 'CALL_EXCEPTION';
const CONTRACT_REVERT_EXECUTED_CODE = 3;
const GAS_LIMIT_1_000_000 = { gasLimit: 1_000_000 };
const GAS_LIMIT_2_000_000 = { gasLimit: 2_000_000 };
const GAS_LIMIT_10_000_000 = { gasLimit: 10_000_000 };
const GAS_LIMIT_800000 = { gasLimit: 800000 };
const GAS_LIMIT_8000000 = { gasLimit: 8000000 };
Expand All @@ -223,6 +226,7 @@ const HOUR = 60 * MINUTE;
const DAY = 24 * HOUR;
const WEEK = 7 * DAY;
const GWEI = 1e9;
const HTS_SYSTEM_CONTRACT_ID = '0.0.359';

module.exports = {
Events,
Expand All @@ -231,6 +235,7 @@ module.exports = {
CALL_EXCEPTION,
CONTRACT_REVERT_EXECUTED_CODE,
GAS_LIMIT_1_000_000,
GAS_LIMIT_2_000_000,
GAS_LIMIT_10_000_000,
GAS_LIMIT_800000,
GAS_LIMIT_8000000,
Expand All @@ -245,4 +250,5 @@ module.exports = {
WEEK,
WEI,
GWEI,
HTS_SYSTEM_CONTRACT_ID,
};
Loading