azurerm_data_protection_backup_vault - support for immutability property #27859
+47
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbfrahry
requested changes
Nov 12, 2024
internal/services/dataprotection/data_protection_backup_vault_resource.go
Outdated
Show resolved
Hide resolved
internal/services/dataprotection/data_protection_backup_vault_resource.go
Show resolved
Hide resolved
github-actions
bot
added
size/M
waiting-response
and removed
waiting-response
size/S
labels
mbfrahry
requested changes
Nov 15, 2024
internal/services/dataprotection/data_protection_backup_vault_resource.go
Outdated
Show resolved
Hide resolved
internal/services/dataprotection/data_protection_backup_vault_resource.go
Outdated
Show resolved
Hide resolved
| @@ -55,7 +55,9 @@ The following arguments are supported: | |||
|
|
|||
| -> **Note:** The `retention_duration_in_days` is the number of days for which deleted data is retained before being permanently deleted. Retention period till 14 days are free of cost, however, retention beyond 14 days may incur additional charges. The `retention_duration_in_days` is required when the `soft_delete` is set to `On`. | |||
|
|
|||
| * `soft_delete` - (Optional) The state of soft delete for this Backup Vault. Possible values are `AlwaysOn`, `Off` and `On`. Defaults to `On`. | |||
| * `immutability` - (Optional) The state of immutability for this Backup Vault. Possible values are `Disabled`, `Locked`, and `Unlocked`. Defaults to `Disabled`. Changing this from `Locked` to anything else forces a new Backup Vault to be created. | |||
There was a problem hiding this comment.
This is more for if we want the naming to be better but I think Unlocked isn't very clear that it's actually enabling immutability. It'd be a bit more work on our end but what are your thoughts on changing Unlocked to Enabled?
There was a problem hiding this comment.
I think its best if we just keep it matching the API values even if the portal uses something else here despite it being confusing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Log
Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.
azurerm_data_protection_backup_vault- support for immutability property [GH-00000]This is a (please select all that apply):
Related Issue(s)
Fixes #22238
Note
If this PR changes meaningfully during the course of review please update the title and description as required.