Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
azurerm_data_protection_backup_vault - support for immutability property #27859
base: main
Are you sure you want to change the base?
azurerm_data_protection_backup_vault - support for immutability property #27859
Changes from 6 commits
2c15bfb
e3ced2c
79b667b
4a05500
7bb50a8
d67ab8e
3176604
232f3c9
607e0c6
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check failure on line 244 in internal/services/dataprotection/data_protection_backup_vault_resource.go
GitHub Actions / golint
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is more for if we want the naming to be better but I think
Unlocked
isn't very clear that it's actually enabling immutability. It'd be a bit more work on our end but what are your thoughts on changingUnlocked
toEnabled
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think its best if we just keep it matching the API values even if the portal uses something else here despite it being confusing