Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility with Kotori: Add timestamp field into outbound telemetry message #111

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

amotl
Copy link
Member

@amotl amotl commented Nov 20, 2021

Hi there,

this patch adds a timestamp field into the outbound telemetry message. The implementation should probably be improved, at least by making this detail configurable.

Currently, we are using the timestamp of the first reading, which also might have room for improvements.

With kind regards,
Andreas.

@amotl amotl marked this pull request as draft November 20, 2021 18:48
@amotl
Copy link
Member Author

amotl commented Nov 20, 2021

When thinking about this once more, and when looking at the ci job #4274673219, it looks like the MQTT payload already includes three timestamp fields:

system.runtime                            17.281501054763794                          
system.time                                1637434163.607122                          
system.uptime                             1637434163.6071224                          

So, there would be no need to introduce another one. Instead, we can make Kotori learn about them.

@amotl amotl changed the title Add timestamp field into outbound telemetry message Compatibility with Kotori: Add timestamp field into outbound telemetry message Nov 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant