Show redirect link to validator if bioformats2raw #240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
will-moore
force-pushed
the
redirect_bioformats2raw
branch
from
df4f250 to
ed02ee1
Compare
manzt
approved these changes
Feb 24, 2025
Comment on lines
+153
to
+158
| if ((err as Error).name === "RedirectError") { | ||
| let redirect = err as RedirectError; | ||
| set(redirectObjAtom, { message: redirect.message, url: redirect.url }); | ||
| } else { | ||
| set(sourceErrorAtom, (err as Error).message); | ||
| } |
There was a problem hiding this comment.
Might touch some of this to try to avoid type assertions in follow up PR.
|
Looks great. We can work on the UI in a follow up PR. Thanks for taking care of this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #149.
This is an implementation of #149 (comment) to provide a redirect link to ome-ngff-validator if the image is a bioformats2raw.layout.
The validator will show the Series of images in the collection, each with a link to open in vizarr etc.
To test:
https://deploy-preview-240--vizarr.netlify.app/?source=https://storage.googleapis.com/jax-public-ngff-2024/public_data/1851/whitej_205/2020-10/28/12-38-38.406/K99691_10.zarr