Matter TemperatureNumber feature from TemperatureControl cluster #128838
Conversation
home-assistant
bot
added
cla-signed
Hacktoberfest
integration: matter
new-feature
labels
|
Hey there @home-assistant/matter, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
|
Is there a HomeAssistant entity to map this cluster with? |
|
You should add/integrate this code into the |
Co-authored-by: Marcel van der Veldt <[email protected]>
|
@lboue can you address the final feedback, rebase the PR and fix any merge conflicts ? |
| if self._feature_map == feature_map: | ||
| return | ||
| self._feature_map = feature_map | ||
| self._attr_hvac_modes: list[HVACMode] = [HVACMode.HEAT_COOL] |
There was a problem hiding this comment.
Add a comment above this line that you can not set the mode for a TemperatureControl cluster, you can only set the target temperature.
Also I'm wondering if heat_cool is the right mode here. Can we somewhere determine if this device is either a cooling or heating device ? I think we can derive that from the device type maybe ?
So if we know from the devicetype that its a fridge, we should hardcode this mode to cooling
There was a problem hiding this comment.
I set it to HVACMode.HEAT_COOL because TemperatureControlledCabinet device type can have cooling/heating functionality:
https://github.com/project-chip/connectedhomeip/blob/master/data_model/1.4/device_types/TemperatureControlledCabinet.xml
There was a problem hiding this comment.
The difficulty here is that it concerns a different EP. In the case of a refrigerator (fridge + freezer) there is 3 EP:
- Endpoint 1: Device Type(s): Refrigerator
- Endpoint 2: Device Type(s): Temperature Controlled Cabinet
- Endpoint 3: Device Type(s): Temperature Controlled Cabinet
There was a problem hiding this comment.
yes you should look at root endpoint if its a refrigerator
There was a problem hiding this comment.
EP0 device type is 'Root Node' so we can't use that trick:
"attributes": {
"0/29/0": [
{
"0": 22,
"1": 1
}
],There was a problem hiding this comment.
From the specs :
24-27351-005_Matter-1.4-Device-Library-Specification.pdf (page 121)
So maybe with TagList attribute of the Descriptor cluster.
Co-authored-by: Marcel van der Veldt <[email protected]>
Co-authored-by: Marcel van der Veldt <[email protected]>
Co-authored-by: Marcel van der Veldt <[email protected]>
Co-authored-by: Marcel van der Veldt <[email protected]>
Attributes of Descriptor Cluster
TagList / AttributeId: 4 (0x004) - Value type: Optional[List[Descriptor.Structs.SemanticTagStruct]]
kNamespaceRefrigerator = 0x41
kTagRefrigerator
[{"0":null,"1":65,"2":0}]
TagFreezer
[{"0":null,"1":65,"2":1}]
Proposed change
It would be useful to add support for Matter Temperature Control Cluster (0x0056) used in the following device types:
This would allow manufacturers to test their products.
This cluster provides an interface to the setpoint temperature on devices such as washers, refrigerators, and water heaters. The setpoint temperature is the temperature to which a device using this cluster would attempt to control to. This cluster does not provide access to the actual or physical temperature associated with any device using this cluster. Access to the physical temperature associated with a device using this cluster would be provided by other clusters as part of that devices
device type definition.
There is 3 features for this cluster:
For devices that use an actual temperature value for the temperature setpoint, such as some water heaters
For devices that support discrete temperature setpoints that are larger than the temperature resolution imposed via the temperature data type
For devices that use vendor-specific temperature levels for the temperature setpoint, such as some washers (Dishwasher, LaundryDryer, LaundryWasher)
There is one command to change the target Temperature:
SupportedTemperatureLevels (86/5) is a
list[Str]Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: