Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Matter TemperatureNumber feature from TemperatureControl cluster #128838
base: dev
Are you sure you want to change the base?
Matter TemperatureNumber feature from TemperatureControl cluster #128838
Changes from all commits
5010f44
ab9c7a0
3dcfd71
41615a0
3713603
be1cd73
1bc8a01
ae7d853
008b5b9
ded711e
d7aee69
70887f9
b857efe
46c18ea
a9af663
22a4c18
2acd72e
43ef56c
564821d
7a68c68
d5c4f1b
68bf4df
ddca2d4
e1c332d
f0b6716
8297fd4
35183bc
fefe07a
bbee0ed
d2d4f39
59d1391
ad5de14
08fa381
3e59c9b
08c9b4d
b8432cb
72684c2
f26de81
b449484
8d0441b
0876e57
a75be25
bb145af
d234416
b48a8d5
b7e3032
9e73d30
86860bf
231b66f
1b8d7f8
ac3b6bc
39db882
c9c24b4
ae3eb5a
49f9a75
495849d
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add a comment above this line that you can not set the mode for a TemperatureControl cluster, you can only set the target temperature.
Also I'm wondering if heat_cool is the right mode here. Can we somewhere determine if this device is either a cooling or heating device ? I think we can derive that from the device type maybe ?
So if we know from the devicetype that its a fridge, we should hardcode this mode to cooling
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I set it to
HVACMode.HEAT_COOL
becauseTemperatureControlledCabinet
device type can have cooling/heating functionality:https://github.com/project-chip/connectedhomeip/blob/master/data_model/1.4/device_types/TemperatureControlledCabinet.xml
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The difficulty here is that it concerns a different EP. In the case of a refrigerator (fridge + freezer) there is 3 EP:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes you should look at root endpoint if its a refrigerator
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
EP0 device type is 'Root Node' so we can't use that trick:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From the specs :
24-27351-005_Matter-1.4-Device-Library-Specification.pdf (page 121)
So maybe with
TagList
attribute of theDescriptor
cluster.