Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Component & Physics syntax #139

Open
wants to merge 65 commits into
base: devel
Choose a base branch
from

Conversation

GiudGiud
Copy link
Contributor

@GiudGiud GiudGiud commented May 23, 2024

The first set of pre-req PRs in MOOSE has been merged
TODO:

  • Get all tests green
  • Finish documentation
  • Verify base Physics capabilities (atm: exodus restart, block restrictions, multi-system)
  • Remove Physics' "component" parameter
  • Develop new ComponentMaterialPropertyInterface
  • Develop new ComponentBoundaryConditionInterface classes
  • Deploy on Structure1D and Enclosure0D
  • Adapt documentation to reflect new syntax

I am not convinced I have the best names for these Physics objects. It would be good to have a TMAP8 practitioner give feedback.
Are SpeciesTrapping and FieldMigration good names?
Are ODE/ContinuousGalerkin what people want to see in their inputs? Do you want less nesting in which case we would need to change the intermediate name? (a more compact Physics/SomethingMigration-or-Trapping+discretization/<name of the object>)

EDITs from conversation with PC:

  • SpeciesTrapping is good
  • PointTrapping is bad, find something else
  • FieldMigration is bad, use DiffusionReaction

Are ODE/ContinuousGalerkin what people want to see in their inputs?

No need to add those. Set a compact syntax, even for MOOSE Physics.


Also, for the Trapping Physics, I am doing a distinction between Field and Point, mainly because a "Point" Physics is using ScalarKernels for a single conservation ODE, while a Field is using nodalKernels for a field of ODEs.
That's not the only option, we could remote Field from the Field physics and use nodal kernels at a point. That would not be shocking, but might take a little bit more development in nodal kernels (no ParsedNodalKernel for example!)

EDIT: rework Point, fix base class

Also, for the Field Trapping Physics, I am saying it is "ContinuousGalerkin" but really it's nodal and could apply to other nodal families. Thoughts on a better name / syntax ?

EDIT: CG deleted from syntax

@GiudGiud GiudGiud force-pushed the PR_new_components branch 2 times, most recently from bd2728b to 1e568f7 Compare May 24, 2024 19:11
@GiudGiud GiudGiud force-pushed the PR_new_components branch 3 times, most recently from 80b81d1 to 1a99007 Compare December 17, 2024 02:29
@GiudGiud GiudGiud force-pushed the PR_new_components branch 3 times, most recently from 30a589b to f22314c Compare January 14, 2025 18:56
@moosebuild
Copy link

moosebuild commented Jan 14, 2025

Job Documentation, step Sync to remote on 39e7e1a wanted to post the following:

View the site here

This comment will be updated on new commits.

@moosebuild
Copy link

Job Precheck, step Format Check Clang on 49e2cee wanted to post the following:

Your code requires style changes.

A patch was auto generated and copied here
You can directly apply the patch by running, in the top level of your repository:

curl -s https://mooseframework.inl.gov/tmap8/docs/PRs/139/clang_format/style.patch | git apply -v

Alternatively, with your repository up to date and in the top level of your repository:

git clang-format 980dc846b06b6864b8275b6575567aca09952355

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants