-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Component & Physics syntax #139
base: devel
Are you sure you want to change the base?
Conversation
bd2728b
to
1e568f7
Compare
feb98b1
to
829a3c1
Compare
829a3c1
to
b8c4e17
Compare
b8c4e17
to
8dded03
Compare
80b81d1
to
1a99007
Compare
30a589b
to
f22314c
Compare
Job Documentation, step Sync to remote on 39e7e1a wanted to post the following: View the site here This comment will be updated on new commits. |
39e7e1a
to
4afc429
Compare
Re-create val-1a test with components refs idaholab#8
…gPhysics live there Rework 1D structure to use a DiffusionPhysics refs idaholab#8
this gives us more flexibility for the input of T from Physics when there is no T variable
Use full kb value
- dont use default preconditioning as its insufficiently tight in parallel - reorder tests - fix test requirements notably duplicates
Add more parameter groups
Add an underlying mesh to enclosure0D: - this will enable transitioning from scalar variables to a nodal variable on a single node - it helps with the logic for functor property nodal evaluations
4afc429
to
77350fa
Compare
Change Physics syntaxes in registration
name sanctioned by PC
Rework: - trim base class, provides a few parameters and a few utilities - force either using a default for each component and each species specified in the Physics or specify the parameter in every component for every species
77350fa
to
49e2cee
Compare
Job Precheck, step Format Check Clang on 49e2cee wanted to post the following: Your code requires style changes. A patch was auto generated and copied here
Alternatively, with your repository up to date and in the top level of your repository:
|
49e2cee
to
c735b55
Compare
The first set of pre-req PRs in MOOSE has been merged
TODO:
I am not convinced I have the best names for these Physics objects. It would be good to have a TMAP8 practitioner give feedback.
Are SpeciesTrapping and FieldMigration good names?
Are ODE/ContinuousGalerkin what people want to see in their inputs? Do you want less nesting in which case we would need to change the intermediate name? (a more compact
Physics/SomethingMigration-or-Trapping+discretization/<name of the object>
)EDITs from conversation with PC:
No need to add those. Set a compact syntax, even for MOOSE Physics.
Also, for the Trapping Physics, I am doing a distinction between Field and Point, mainly because a "Point" Physics is using ScalarKernels for a single conservation ODE, while a Field is using nodalKernels for a field of ODEs.
That's not the only option, we could remote Field from the Field physics and use nodal kernels at a point. That would not be shocking, but might take a little bit more development in nodal kernels (no ParsedNodalKernel for example!)
EDIT: rework Point, fix base class
Also, for the Field Trapping Physics, I am saying it is "ContinuousGalerkin" but really it's nodal and could apply to other nodal families. Thoughts on a better name / syntax ?
EDIT: CG deleted from syntax