-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change receipts 394 to a TBD with IANA Considerations #332
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: steve lasker <[email protected]>
Signed-off-by: steve lasker <[email protected]>
## COSE Receipts Header Parameter | ||
|
||
{{-COMETRE}} is requesting IANA to add the following entries to the [COSE Header Algorithm Parameters Registry](https://www.iana.org/assignments/cose/cose.xhtml). | ||
|
||
- Name: receipts | ||
- Label: TBD_0 (requested assignment 394) | ||
- Value type: array (of bstr) | ||
- Value registry: https://www.iana.org/assignments/cose/cose.xhtml#header-parameters | ||
- Description: Priority ordered list of CBOR encoded Receipts. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the authors of that spec are requesting it for that draft, why are we doubling that request here? Do we not need to specify we want to replace the values later once that is formalized with an explanation between this section and the previous header?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a little repetitive. We must change 394, as it creates confusion for implementors. This section was copy/pasted over for completeness. Either way, when TBD_0 is assigned, this will get cleaned up, so I felt it was helpful to provide a pointer.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is weird... you are duplicating the registration request from an existing draft:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, although we should go and try to get allocation ASAP
@@ -1009,6 +1009,16 @@ It is up to the Issuer to notify Transparency Services of credential revocation | |||
|
|||
# IANA Considerations | |||
|
|||
## COSE Receipts Header Parameter |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Normally you would request IANA with definitive number ranges for your work!
Please check with @henkbirkholz how best we can handle this ?
Adding IANA Considerations is a great start!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See my suggestions!
{{-COMETRE}} is requesting IANA to add the following entries to the [COSE Header Algorithm Parameters Registry](https://www.iana.org/assignments/cose/cose.xhtml). | ||
|
||
- Name: receipts | ||
- Label: TBD_0 (requested assignment 394) | ||
- Value type: array (of bstr) | ||
- Value registry: https://www.iana.org/assignments/cose/cose.xhtml#header-parameters | ||
- Description: Priority ordered list of CBOR encoded Receipts. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
{{-COMETRE}} is requesting IANA to add the following entries to the [COSE Header Algorithm Parameters Registry](https://www.iana.org/assignments/cose/cose.xhtml). | |
- Name: receipts | |
- Label: TBD_0 (requested assignment 394) | |
- Value type: array (of bstr) | |
- Value registry: https://www.iana.org/assignments/cose/cose.xhtml#header-parameters | |
- Description: Priority ordered list of CBOR encoded Receipts. | |
TBD_0 is requested in {{-COMETRE}}. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch @OR13 : I think, then we do not need this PR??
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this is the ONLY tag, then we can drop this PR, as suggested by @OR13
Fixes #326