Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change receipts 394 to a TBD with IANA Considerations #332

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

SteveLasker
Copy link
Collaborator

Fixes #326

Comment on lines +1031 to +1040
## COSE Receipts Header Parameter

{{-COMETRE}} is requesting IANA to add the following entries to the [COSE Header Algorithm Parameters Registry](https://www.iana.org/assignments/cose/cose.xhtml).

- Name: receipts
- Label: TBD_0 (requested assignment 394)
- Value type: array (of bstr)
- Value registry: https://www.iana.org/assignments/cose/cose.xhtml#header-parameters
- Description: Priority ordered list of CBOR encoded Receipts.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the authors of that spec are requesting it for that draft, why are we doubling that request here? Do we not need to specify we want to replace the values later once that is formalized with an explanation between this section and the previous header?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a little repetitive. We must change 394, as it creates confusion for implementors. This section was copy/pasted over for completeness. Either way, when TBD_0 is assigned, this will get cleaned up, so I felt it was helpful to provide a pointer.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aj-stein, do still feel strongly? I'd like to merge to get to #341

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is weird... you are duplicating the registration request from an existing draft:

https://datatracker.ietf.org/doc/html/draft-ietf-cose-merkle-tree-proofs-07#name-new-entries-to-the-cose-hea

@SteveLasker SteveLasker requested a review from aj-stein January 22, 2025 18:50
Copy link
Contributor

@JAG-UK JAG-UK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, although we should go and try to get allocation ASAP

@@ -1009,6 +1009,16 @@ It is up to the Issuer to notify Transparency Services of credential revocation

# IANA Considerations

## COSE Receipts Header Parameter
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Normally you would request IANA with definitive number ranges for your work!

Please check with @henkbirkholz how best we can handle this ?

Adding IANA Considerations is a great start!

Copy link
Collaborator

@yogeshbdeshpande yogeshbdeshpande left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my suggestions!

Comment on lines +1014 to +1020
{{-COMETRE}} is requesting IANA to add the following entries to the [COSE Header Algorithm Parameters Registry](https://www.iana.org/assignments/cose/cose.xhtml).

- Name: receipts
- Label: TBD_0 (requested assignment 394)
- Value type: array (of bstr)
- Value registry: https://www.iana.org/assignments/cose/cose.xhtml#header-parameters
- Description: Priority ordered list of CBOR encoded Receipts.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
{{-COMETRE}} is requesting IANA to add the following entries to the [COSE Header Algorithm Parameters Registry](https://www.iana.org/assignments/cose/cose.xhtml).
- Name: receipts
- Label: TBD_0 (requested assignment 394)
- Value type: array (of bstr)
- Value registry: https://www.iana.org/assignments/cose/cose.xhtml#header-parameters
- Description: Priority ordered list of CBOR encoded Receipts.
TBD_0 is requested in {{-COMETRE}}.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch @OR13 : I think, then we do not need this PR??

Copy link
Collaborator

@yogeshbdeshpande yogeshbdeshpande left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this is the ONLY tag, then we can drop this PR, as suggested by @OR13

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make reference to Receipt Label 394 a TBD
6 participants