Change receipts 394 to a TBD with IANA Considerations #332
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -767,7 +767,7 @@ Client applications MAY request Receipts regardless of the identity of the Issue | |||||||||||||||||
| When a Signed Statement is registered by a Transparency Service a Receipt becomes available. | ||||||||||||||||||
| When a Receipt is included in a Signed Statement a Transparent Statement is produced. | ||||||||||||||||||
|
|
||||||||||||||||||
| Receipts are based on Signed Inclusion Proofs as described in COSE Signed Merkle Tree Proofs ({{-COMETRE}}) that also provides the COSE header parameter semantics for label TBD_0. | ||||||||||||||||||
|
|
||||||||||||||||||
| The Registration time is recorded as the timestamp when the Transparency Service added this Signed Statement to its Append-only Log. | ||||||||||||||||||
|
|
||||||||||||||||||
|
|
@@ -780,14 +780,14 @@ See {{fig-signed-statement-cddl}} for the CDDL rule that defines 'COSE_Sign1' as | |||||||||||||||||
| {: #fig-transparent-statement-cddl title="CDDL definition for a Transparent Statement"} | ||||||||||||||||||
|
|
||||||||||||||||||
| {{fig-transparent-statement-edn}} illustrates a Transparent Statement with a detached payload, and two Receipts in its unprotected header. | ||||||||||||||||||
| The type of label TBD_0 `receipts` in the unprotected header is a CBOR array that can contain one or more Receipts (each entry encoded as a .cbor encoded Receipts). | ||||||||||||||||||
|
|
||||||||||||||||||
| ~~~ cbor-diag | ||||||||||||||||||
| 18( / COSE Sign 1 / | ||||||||||||||||||
| [ | ||||||||||||||||||
| h'a4012603...6d706c65', / Protected / | ||||||||||||||||||
| { / Unprotected / | ||||||||||||||||||
| TBD_0: [ / Receipts (2) / | ||||||||||||||||||
| h'd284586c...4191f9d2' / Receipt 1 / | ||||||||||||||||||
| h'c624586c...8f4af97e' / Receipt 2 / | ||||||||||||||||||
| ] | ||||||||||||||||||
|
|
@@ -1028,6 +1028,16 @@ It is up to the Issuer to notify Transparency Services of credential revocation | |||||||||||||||||
|
|
||||||||||||||||||
| # IANA Considerations | ||||||||||||||||||
|
|
||||||||||||||||||
| ## COSE Receipts Header Parameter | ||||||||||||||||||
|
|
||||||||||||||||||
| {{-COMETRE}} is requesting IANA to add the following entries to the [COSE Header Algorithm Parameters Registry](https://www.iana.org/assignments/cose/cose.xhtml). | ||||||||||||||||||
|
|
||||||||||||||||||
| - Name: receipts | ||||||||||||||||||
| - Label: TBD_0 (requested assignment 394) | ||||||||||||||||||
| - Value type: array (of bstr) | ||||||||||||||||||
| - Value registry: https://www.iana.org/assignments/cose/cose.xhtml#header-parameters | ||||||||||||||||||
| - Description: Priority ordered list of CBOR encoded Receipts. | ||||||||||||||||||
|
Comment on lines
+1014
to
+1020
There was a problem hiding this comment.
Suggested change
There was a problem hiding this comment. Good catch @OR13 : I think, then we do not need this PR?? |
||||||||||||||||||
|
|
||||||||||||||||||
|
Comment on lines
+1012
to
+1021
There was a problem hiding this comment. If the authors of that spec are requesting it for that draft, why are we doubling that request here? Do we not need to specify we want to replace the values later once that is formalized with an explanation between this section and the previous header? There was a problem hiding this comment. It's a little repetitive. We must change 394, as it creates confusion for implementors. This section was copy/pasted over for completeness. Either way, when TBD_0 is assigned, this will get cleaned up, so I felt it was helpful to provide a pointer. There was a problem hiding this comment. This is weird... you are duplicating the registration request from an existing draft: |
||||||||||||||||||
| ## Media Type Registration | ||||||||||||||||||
|
|
||||||||||||||||||
| Pending WG discussion. | ||||||||||||||||||
|
|
||||||||||||||||||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,5 @@ | ||
| Transparent_Statement = #6.18(COSE_Sign1) | ||
|
|
||
| Unprotected_Header = { | ||
| &(receipts: TBD_0) => [+ Receipt] | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Normally you would request IANA with definitive number ranges for your work!
Please check with @henkbirkholz how best we can handle this ?
Adding IANA Considerations is a great start!