Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: avoid create duplicated scopedKeppers #4216

Merged
merged 2 commits into from
Jun 27, 2024

Conversation

Pantani
Copy link
Collaborator

@Pantani Pantani commented Jun 27, 2024

close #4066

Description

Since we are not using the module keeper as a pointer, the scoped keeper can't be saved inside the keeper structure, causing chain crashes. This PR makes the App handle the scoped keeper logic.

@Pantani Pantani requested review from salmad3 and toschdev as code owners June 27, 2024 17:01
Copy link
Member

@julienrbrt julienrbrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@julienrbrt julienrbrt added the backport/v28.x.y Backport to v28.x.y label Jun 27, 2024
@julienrbrt julienrbrt enabled auto-merge (squash) June 27, 2024 19:32
@julienrbrt julienrbrt merged commit 6c22a43 into main Jun 27, 2024
45 checks passed
@julienrbrt julienrbrt deleted the fix/duplicated-scoped-keeper branch June 27, 2024 19:32
mergify bot pushed a commit that referenced this pull request Jun 27, 2024
* avoid create duplicated scopedKeppers

* add changelog

(cherry picked from commit 6c22a43)
Pantani added a commit that referenced this pull request Jun 28, 2024
* avoid create duplicated scopedKeppers

* add changelog

(cherry picked from commit 6c22a43)

Co-authored-by: Danilo Pantani <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/v28.x.y Backport to v28.x.y component:ci CI/CD workflow and automated jobs. component:configs component:templates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Faucet is not opearational when trying to configure a relayer
2 participants