-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: improve streeet search component #741
Conversation
0fac3bf
to
5815bce
Compare
5815bce
to
0814b3c
Compare
3ce5ad0
to
5ced6ec
Compare
4ee4765
to
88833dd
Compare
@derrabauke As an additional fix, we should ensure that building creation handles errors graciously, i.e. if when saving a building, if the addWork request fails or the addBuildingToConstructionProject, then the building should be left in a new state. At the moment we trigger modifyBuilding requests after a failed addBuildingToConstructionProject because the isNew flag isn't rolled back correctly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👌
🎉 This PR is included in version 7.6.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
First part of implementing #738
Building creation
Street validation
Preview
Disabled + invalid state (same as disabled)
Enabled + invalid state
Enabled + valid state