Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve streeet search component #741

Merged
merged 6 commits into from
Apr 18, 2024

Conversation

derrabauke
Copy link
Contributor

@derrabauke derrabauke commented Apr 5, 2024

First part of implementing #738

Building creation

  • Remove locality name as an input field, getStreet only uses the PLZ
  • Display the locality name in the street search options
  • Use the locality returned in the getStreet response for the addBuildingToConstructionProject request

Street validation

  • Make the street input required through a validation check

Preview

Disabled + invalid state (same as disabled)

image

Enabled + invalid state

image

Enabled + valid state

image

@derrabauke derrabauke added the enhancement New feature or request label Apr 5, 2024
@derrabauke derrabauke self-assigned this Apr 5, 2024
@derrabauke derrabauke force-pushed the fix-street-search-lang branch 3 times, most recently from 0fac3bf to 5815bce Compare April 5, 2024 14:24
@derrabauke derrabauke force-pushed the fix-street-search-lang branch from 5815bce to 0814b3c Compare April 5, 2024 14:48
@derrabauke derrabauke force-pushed the fix-street-search-lang branch from 3ce5ad0 to 5ced6ec Compare April 9, 2024 07:04
@derrabauke derrabauke marked this pull request as ready for review April 9, 2024 07:10
@derrabauke derrabauke requested a review from luytena April 9, 2024 07:10
@derrabauke derrabauke mentioned this pull request Apr 9, 2024
4 tasks
@derrabauke derrabauke force-pushed the fix-street-search-lang branch from 4ee4765 to 88833dd Compare April 9, 2024 07:31
@luytena
Copy link
Contributor

luytena commented Apr 9, 2024

@derrabauke As an additional fix, we should ensure that building creation handles errors graciously, i.e. if when saving a building, if the addWork request fails or the addBuildingToConstructionProject, then the building should be left in a new state. At the moment we trigger modifyBuilding requests after a failed addBuildingToConstructionProject because the isNew flag isn't rolled back correctly.

@derrabauke
Copy link
Contributor Author

derrabauke commented Apr 9, 2024

@luytena As an additional fix, we should ensure that building creation handles errors graciously, [...]

Can we resolve that in the separate issue #743 ?

@luytena
Copy link
Contributor

luytena commented Apr 9, 2024

@luytena As an additional fix, we should ensure that building creation handles errors graciously, [...]

Can we resolve that in the separate issue #743 ?

Yes, sure. I just needed to place it somewhere where I wouldn't forget.

@derrabauke derrabauke requested a review from czosel April 11, 2024 15:57
Copy link
Contributor

@luytena luytena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👌

@luytena luytena merged commit 4f29486 into inosca:main Apr 18, 2024
10 checks passed
@luytena
Copy link
Contributor

luytena commented Jul 17, 2024

🎉 This PR is included in version 7.6.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants