BlockMetadataResponse 2.0 update #700
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thibault-martinez
force-pushed
the
2.0
branch
2 times, most recently
from
a1a4396
to
187caed
Compare
thibault-martinez
force-pushed
the
block-metadata
branch
from
4c47267
to
e92ba4d
Compare
| Pending, | ||
| // Confirmed with the first level of knowledge. | ||
| Confirmed, | ||
| // Included and cannot be reverted anymore. |
There was a problem hiding this comment.
Suggested change
| // Included and cannot be reverted anymore. | |
| // Included and can no longer be reverted. |
| @@ -141,22 +160,21 @@ pub enum LedgerInclusionState { | |||
| )] | |||
| pub struct BlockMetadataResponse { | |||
| pub block_id: BlockId, | |||
| pub parents: Vec<BlockId>, | |||
| pub is_solid: bool, | |||
| pub strong_parents: Vec<BlockId>, | |||
| #[cfg_attr(feature = "serde", serde(skip_serializing_if = "Option::is_none"))] | |||
There was a problem hiding this comment.
Can we add default to all of these?
| pub enum ConflictReason { | ||
| /// The block has no conflict. | ||
| None = 0, | ||
| /// The referenced Utxo was already spent. | ||
| InputUtxoAlreadySpent = 1, | ||
| /// The referenced Utxo was already spent while confirming this milestone. | ||
| /// TODO weird |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.