Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: updated to turbo v2 #72

Merged
merged 2 commits into from
Jun 9, 2024
Merged

feat: updated to turbo v2 #72

merged 2 commits into from
Jun 9, 2024

Conversation

imCorfitz
Copy link
Collaborator

No description provided.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jun 8, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: e676ce4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

ixahmedxi
ixahmedxi reviewed Jun 8, 2024
View reviewed changes
package.json
"typescript": "^5.4.5",
"yargs": "^17.7.2"
}
},
"packageManager": "[email protected]"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does this actually work?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This entire commit is the result of running npx @turbo/codemod migrate ... And all turbo commands continue to work. Removing the packageManager makes turbo bark at me.
Screenshot 2024-06-08 at 12 33 15

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ohhh makes sense then.

ixahmedxi
ixahmedxi previously approved these changes Jun 8, 2024
View reviewed changes
@imCorfitz
fix(env): using dot notation
e676ce4 
bun turbo lint barked as it preferred dot notation instead of square brackets
@imCorfitz
Copy link
Collaborator Author

I also added a fix for the bun turbo lint command, which failed for @orbitkit/env pacakge.
Screenshot 2024-06-09 at 14 24 56

imCorfitz
imCorfitz commented Jun 9, 2024
View reviewed changes
packages/env/src/web.ts
@@ -27,7 +27,7 @@ export const env = createEnv({
},
client: {},
experimental__runtimeEnv: {
NODE_ENV: process.env['NODE_ENV'],
NODE_ENV: process.env.NODE_ENV,
},
emptyStringAsUndefined: true,
skipValidation: !!process.env['SKIP_ENV_VALIDATION'],
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Curious why eslint doesn't have a problem with ['SKIP_ENV_VALIDATION']

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

because NODE_ENV is known to be on process.env but SKIP_ENV_VALIDATION isn't

@ixahmedxi ixahmedxi merged commit e2ab419 into ixahmedxi:main Jun 9, 2024
4 of 5 checks passed
@imCorfitz imCorfitz deleted the update/turbo branch June 9, 2024 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ixahmedxi ixahmedxi ixahmedxi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@imCorfitz @ixahmedxi