Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: updated to turbo v2 #72

Merged
merged 2 commits into from
Jun 9, 2024
Merged

feat: updated to turbo v2 #72

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
37d95b4
feat: updated to turbo v2
imCorfitz Jun 8, 2024
e676ce4
fix(env): using dot notation
imCorfitz Jun 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ To contribute to this project, follow these steps:
### Prerequisites

```shell
bun: ">=1.1.9"
bun: ">=1.1.12"
```

### Setting up your local repo
Expand Down
2 changes: 1 addition & 1 deletion apps/marketing/turbo.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"$schema": "https://turbo.build/schema.json",
"extends": ["//"],
"pipeline": {
"tasks": {
"lint": {
"dependsOn": ["^build", "build"],
"inputs": [
Expand Down
Binary file modified bun.lockb
View file
Open in desktop
Binary file not shown.
5 changes: 3 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,8 +67,9 @@
"prettier-plugin-curly": "^0.2.1",
"prettier-plugin-packagejson": "^2.5.0",
"rimraf": "^5.0.7",
"turbo": "^1.13.3",
"turbo": "^2.0.3",
"typescript": "^5.4.5",
"yargs": "^17.7.2"
}
},
"packageManager": "[email protected]"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does this actually work?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This entire commit is the result of running npx @turbo/codemod migrate ... And all turbo commands continue to work. Removing the packageManager makes turbo bark at me.
Screenshot 2024-06-08 at 12 33 15

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ohhh makes sense then.

}
2 changes: 1 addition & 1 deletion packages/env/src/web.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ export const env = createEnv({
},
client: {},
experimental__runtimeEnv: {
NODE_ENV: process.env['NODE_ENV'],
NODE_ENV: process.env.NODE_ENV,
},
emptyStringAsUndefined: true,
skipValidation: !!process.env['SKIP_ENV_VALIDATION'],
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Curious why eslint doesn't have a problem with ['SKIP_ENV_VALIDATION']

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

because NODE_ENV is known to be on process.env but SKIP_ENV_VALIDATION isn't

Expand Down
4 changes: 2 additions & 2 deletions turbo.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"$schema": "https://turbo.build/schema.json",
"globalDotEnv": ["apps/web/.env.local"],
"pipeline": {
"globalDependencies": ["apps/web/.env.local"],
"tasks": {
"build": {
"dependsOn": ["^build", "^db:migrate"],
"inputs": [
Expand Down
Loading