-
-
Notifications
You must be signed in to change notification settings - Fork 489
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate WebSockets to new SocketApi from SDK #1456
Merged
nielsvanvelzen
merged 3 commits into
jellyfin:master
from
nielsvanvelzen:sdk-websockets
Mar 28, 2022
Merged
Migrate WebSockets to new SocketApi from SDK #1456
nielsvanvelzen
merged 3 commits into
jellyfin:master
from
nielsvanvelzen:sdk-websockets
Mar 28, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
nielsvanvelzen
force-pushed
the
sdk-websockets
branch
from
February 19, 2022 10:29
a9aee39
to
0e37aea
Compare
nielsvanvelzen
force-pushed
the
sdk-websockets
branch
2 times, most recently
from
February 20, 2022 13:16
49c9ab6
to
59c10c4
Compare
nielsvanvelzen
force-pushed
the
sdk-websockets
branch
2 times, most recently
from
March 3, 2022 13:38
573ec37
to
5c4236e
Compare
nielsvanvelzen
added
the
next-release
Pull request related to a future release which is not being worked on yet
label
Mar 4, 2022
nielsvanvelzen
removed
the
next-release
Pull request related to a future release which is not being worked on yet
label
Mar 17, 2022
nielsvanvelzen
force-pushed
the
sdk-websockets
branch
2 times, most recently
from
March 26, 2022 18:30
73a464d
to
773cd07
Compare
DavidFair
reviewed
Mar 27, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some general design points whilst this is a draft PR (so I'm hoping open to change).
I'm looking forward as the project gradually migrates to the new SDK though, nice work 👍
app/src/main/java/org/jellyfin/androidtv/data/eventhandling/SocketHandler.kt
Show resolved
Hide resolved
app/src/main/java/org/jellyfin/androidtv/data/eventhandling/SocketHandler.kt
Show resolved
Hide resolved
app/src/main/java/org/jellyfin/androidtv/data/eventhandling/SocketHandler.kt
Show resolved
Hide resolved
nielsvanvelzen
force-pushed
the
sdk-websockets
branch
from
March 27, 2022 09:00
773cd07
to
bd1e021
Compare
nielsvanvelzen
force-pushed
the
sdk-websockets
branch
from
March 27, 2022 10:28
bd1e021
to
546baa4
Compare
mueslimak3r
reviewed
Mar 27, 2022
app/src/main/java/org/jellyfin/androidtv/data/eventhandling/SocketHandler.kt
Show resolved
Hide resolved
app/src/main/java/org/jellyfin/androidtv/data/eventhandling/SocketHandler.kt
Show resolved
Hide resolved
app/src/main/java/org/jellyfin/androidtv/data/eventhandling/SocketHandler.kt
Show resolved
Hide resolved
mueslimak3r
approved these changes
Mar 28, 2022
nielsvanvelzen
added
the
release-highlight
Pull request might be suitable for mentioning in the release blog post
label
May 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new WebSocket code from the SDK is still in beta. The API should be finished so no changes are expected in the app. Some issues in de SDK right now include unnecessary reconnects on subscription changes and the lack of automatic reconnection logic. These will be fixed before SDK 1.2.0 is released as stable and app 0.14 is released in beta/stable. The current issues are minor and shouldn't prevent us contributors from using the master branch on our devices.
Changes
Documentation for the WebSocket API is available here: https://github.com/jellyfin/jellyfin-sdk-kotlin/blob/master/docs/websockets.md
Issues