WebSocket API rewrite #352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nielsvanvelzen
force-pushed
the
ws-2
branch
6 times, most recently
from
dfb0485
to
f1ee27a
Compare
nielsvanvelzen
force-pushed
the
ws-2
branch
2 times, most recently
from
8e4d5ed
to
76d7bd9
Compare
nielsvanvelzen
force-pushed
the
ws-2
branch
3 times, most recently
from
a408d18
to
46a220a
Compare
|
I'll be fixing the two remaining todo items in separate pull requests so we can get this merged first. |
Maxr1998
requested changes
Mar 26, 2022
jellyfin-api/src/commonMain/kotlin/org/jellyfin/sdk/api/sockets/SocketInstanceConnection.kt
Outdated
Show resolved
Hide resolved
jellyfin-api/src/commonMain/kotlin/org/jellyfin/sdk/api/sockets/data/serializers.kt
Outdated
Show resolved
Hide resolved
jellyfin-api/src/commonMain/kotlin/org/jellyfin/sdk/api/sockets/data/serializers.kt
Outdated
Show resolved
Hide resolved
jellyfin-api/src/commonMain/kotlin/org/jellyfin/sdk/api/sockets/data/SubscriptionType.kt
Outdated
Show resolved
Hide resolved
jellyfin-api/src/commonMain/kotlin/org/jellyfin/sdk/api/sockets/KtorSocketInstanceConnection.kt
Outdated
Show resolved
Hide resolved
jellyfin-api/src/commonMain/kotlin/org/jellyfin/sdk/api/sockets/SocketInstance.kt
Show resolved
Hide resolved
jellyfin-api/src/commonMain/kotlin/org/jellyfin/sdk/api/sockets/helper/KeepAliveHelper.kt
Outdated
Show resolved
Hide resolved
jellyfin-api/src/commonMain/kotlin/org/jellyfin/sdk/api/sockets/helper/ListenerHelper.kt
Outdated
Show resolved
Hide resolved
jellyfin-api/src/commonMain/kotlin/org/jellyfin/sdk/api/sockets/listener/SocketListener.kt
Outdated
Show resolved
Hide resolved
jellyfin-api/src/commonMain/kotlin/org/jellyfin/sdk/api/sockets/listenerRegistration.kt
Outdated
Show resolved
Hide resolved
Maxr1998
approved these changes
Mar 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still working on it but opening the pull request for visibility.
To do: