fix: make /test work with branches #1465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/hold |
msvticket
changed the title
msvticket
force-pushed
the
tracepr
branch
2 times, most recently
from
8564be7 to
d1b0bdf
Compare
msvticket
requested review from
ankitm123 and
tomhobson
and removed request for
ankitm123
the same field was used for storing regexp for command and branch after fixing this I could uncomment some old tests
tomhobson
approved these changes
Nov 15, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tomhobson The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Failed to merge this PR due to:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You couldn't trigger pipelines with /test if they had branches specified. This is fixed with this PR. There where commented out tests that failed without this fix.
I let the trace logs be. They might be useful some other time.