Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reenable manual trigger despite run_if_changed not matching #1586

Merged
merged 1 commit into from
Dec 20, 2023

Conversation

msvticket
Copy link
Member

@msvticket msvticket commented Dec 19, 2023

I noticed that this test
a) Tested the wrong thing
b) Expected the wrong result

fixes jenkins-x/jx#8477

@jenkins-x-bot
Copy link
Contributor

[jx-info] Hi, we've detected that the pipelines in this repository are using a syntax that will soon be deprecated.
We'll continue to update you through PRs as we progress. Please check #8589 for further information.

@jenkins-x-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tomhobson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

I also noticed that this test
a) Tested the wrong thing
b) Expected the wrong result

fixes jenkins-x/jx#8477
@msvticket msvticket changed the title fix: run_if_changed test reenable manual trigger despite run_if_changed not matching Dec 20, 2023
@jenkins-x-bot jenkins-x-bot merged commit b8bcc60 into main Dec 20, 2023
3 checks passed
@msvticket msvticket deleted the runifchangedtest branch January 2, 2024 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lighthouse jobs that have run_if_changed cannot be triggered manually
3 participants