RFFT improvement: remove the double size memory requirement #1367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes the FFT engine wrappers simpler, deduplicates code (reducing potential for bugs in wrappers), at the cost of making the FallbackFFT's redundant work done again if the legacy flag is used.
Ideally rfft would be implemented more efficiently than doing a full FFT, but the FFTFallback is just a slow fill-in for juce::dsp::FFT to still work in the absence of using an external FFT engine. This makes it function like the other engines in not requiring an oversized buffer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On 2017, the JUCE team showed interest in fixing the double size memory requirement of
juce::FFT, this PR does this while also removing duplication and complication in the code.Fabian originally suggested making the FFTFallback's real transform more efficient and avoid producing the intermediate redundant results, but given that it is simply the fallback engine, I chose a method that makes it even less efficient (by using additional memory buffers), as I don't see making it efficient as any priority. In fact, I would consider simplifying the fallback engine even further by removing the conditional
allocas in it.