Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RFFT improvement: remove the double size memory requirement #1367

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

RFFT improvement: remove the double size memory requirement #1367

wants to merge 2 commits into from

Commits on Mar 25, 2024

  1. DRY in FFT engines: legacy spectrum mirroring not part of the engine 

    This makes the FFT engine wrappers simpler, deduplicates code (reducing potential for bugs in wrappers),
at the cost of making the FallbackFFT's redundant work done again if the legacy flag is used.
    @yairchu
    yairchu committed Mar 25, 2024
    Configuration menu
    Copy the full SHA
    7613968 View commit details
    Browse the repository at this point in the history

  2. FFTFallback doesn't require real-FFT buffers to be oversized. 

    Ideally rfft would be implemented more efficiently than doing a full FFT,
but the FFTFallback is just a slow fill-in for juce::dsp::FFT to still work in the absence of using an external FFT engine.
This makes it function like the other engines in not requiring an oversized buffer.
    @yairchu
    yairchu committed Mar 25, 2024
    Configuration menu
    Copy the full SHA
    d722c6b View commit details
    Browse the repository at this point in the history