-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make config.ServerProcess into a Configurable #507
base: main
Are you sure you want to change the base?
Conversation
While at it, we should probably also convert Edit: I think the |
Thanks, I had LauncherEntry in my local branch, but was hoping to minimise changes. As it happens making it Configurable is the easiest way to set the defaults. Assuming |
This will allow us to reuse it
37add76
to
fef3695
Compare
A nice benefit of this is we can autogenerate some of the manually written docs: |
I see why you didn't want to use Is there anything else still required here? It would be nice to merge this, so I can update my code it in #501. |
This isn't useful in the jupyter-server-extension, but it should be useful in
#501 (review)
An added benefit is this makes it easier to add more parameters in future since the declaration of the class and the handling of defaults is now in the same place.