Initialize FD limits on MacOS and Linux platforms at startup #333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e DEFAULT and DESIRED limit constants.
… part of the kaspad_lib crate (this way if these values are changed, they will propagate downstream)
| println!("Current OS file descriptor limit (soft FD limit) is set to {limit}"); | ||
| println!("The kaspad node requires a setting of at least {DESIRED_DAEMON_SOFT_FD_LIMIT} to operate properly."); | ||
| println!("Please increase the limits using the following command:"); | ||
| println!("ulimit -n {DESIRED_DAEMON_SOFT_FD_LIMIT}"); |
There was a problem hiding this comment.
Is it worth making a recommendation in README.md so that this can be done intentionally before the user uses kaspad?
There was a problem hiding this comment.
Perhaps. I don't want to touch the readme right now because of another outstanding PR that needs a review. Now that we have discovered that this works I am much less concerned about this as it appears that rusty will now self-configure in most cases and will only fail to do this in some unusual circumstances, which I am currently not sure what they are... I think the upcoming T11 should show if there are any issues with any types of exotic hardware/setups.
michaelsutton
approved these changes
Nov 27, 2023
smartgoo
pushed a commit
to smartgoo/rusty-kaspa
that referenced
this pull request
Jun 18, 2024
…t#333) * Attempt to initialize OS FD limits during the kaspad startup sequence. * cleanup * Refactor to use setmaxstdio on windows, remove hard limit and increase DEFAULT and DESIRED limit constants. * relocate FD limit constants to daemon so that they are available as a part of the kaspad_lib crate (this way if these values are changed, they will propagate downstream) * rename fd_budget fn to try_set_fd_limit * fix typo (1024->4096) * change 4096 to 4*1024 * lints
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MacOS allows applications to set FD limits. The same should work in Linux if you are running as a root.
This PR adds an initializer that passively attempts to configure the needed settings and warns the user if it cannot do so (the output needs to be
println!()as the logging subsystem is not yet initialized.