Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests: Adl_Utils resolving conflicts #578

Merged
merged 2 commits into from
Nov 3, 2023
Merged

Tests: Adl_Utils resolving conflicts #578

merged 2 commits into from
Nov 3, 2023

Conversation

faytey
Copy link
Contributor

@faytey faytey commented Nov 3, 2023

Pull Request type

Please add the labels corresponding to the type of changes your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build-related changes
  • Documentation content changes
  • Testing
  • Other (please describe):

What is the current behavior?

Resolves: #NA

What is the new behavior?

Does this introduce a breaking change?

Other information

@faytey faytey requested a review from AbdelStark as a code owner November 3, 2023 10:39
@faytey faytey mentioned this pull request Nov 3, 2023
Closed
Sk8erboi84
Sk8erboi84 reviewed Nov 3, 2023
View reviewed changes
Copy link
Collaborator

@Sk8erboi84 Sk8erboi84 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please do scarb fmt for the coding style

@faytey
Copy link
Contributor Author

faytey commented Nov 3, 2023

oopps, always skip that, on it now

@faytey
Copy link
Contributor Author

faytey commented Nov 3, 2023

Done

@zarboq zarboq merged commit 3012364 into keep-starknet-strange:main Nov 3, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sk8erboi84 Sk8erboi84 Sk8erboi84 left review comments

@zarboq zarboq zarboq approved these changes

@AbdelStark AbdelStark Awaiting requested review from AbdelStark

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@faytey @zarboq @Sk8erboi84