Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix email template issue #174

Merged
merged 1 commit into from
Oct 25, 2024
Merged

Fix email template issue #174

merged 1 commit into from
Oct 25, 2024

Conversation

sampath24-ss
Copy link
Contributor

What changes are being made and why?

  • Image Rendering: Ensures that the image in the email is responsive and scales properly, fixing the issue of blurriness and distortion.
  • Code Block Formatting: Replaces backticks with <code> tags to properly render the task ID as inline code in the email.

These changes improve the readability and visual appearance of email notifications generated by Kestra.

How the changes have been QAed?

  1. The image now renders clearly and scales responsively.
  2. The task ID is properly rendered as inline code using the <code> tag.

Setup Instructions

@MilosPaunovic
Copy link
Member

As I'm not really sure how to test this properly, can you take over the review here @Skraye?

@Skraye Skraye self-requested a review October 23, 2024 14:22
Copy link
Member

@Skraye Skraye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Skraye Skraye merged commit 9815e50 into kestra-io:master Oct 25, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants