separating workflow settings and page sttings

kinde-oss · Nov 15, 2024 · 313c444 · 313c444
1 parent ffeaa4f
commit 313c444
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 9 deletions.
diff --git a/projectBundler/projectBundler.go b/projectBundler/projectBundler.go
@@ -187,17 +187,19 @@ func (*KindeProject[TWorkflowSettings, TPageSettings]) readProjectConfiguration(
 
 func (kw *KindeWorkflow[TSettings]) bundleAndIntrospect(ctx context.Context) {
 	workflowBuilder := bundler.NewWorkflowBundler(bundler.BundlerOptions[TSettings]{
-		WorkingFolder: kw.WorkflowRootDirectory,
-		EntryPoints:   kw.EntryPoints,
+		WorkingFolder:       kw.WorkflowRootDirectory,
+		EntryPoints:         kw.EntryPoints,
+		IntrospectionExport: "workflowSettings",
 	})
 	bundlerResult := workflowBuilder.Bundle(ctx)
 	kw.Bundle = bundlerResult
 }
 
 func (kw *KindePage[TSettings]) bundleAndIntrospect(ctx context.Context) {
 	workflowBuilder := bundler.NewWorkflowBundler(bundler.BundlerOptions[TSettings]{
-		WorkingFolder: kw.RootDirectory,
-		EntryPoints:   kw.EntryPoints,
+		WorkingFolder:       kw.RootDirectory,
+		EntryPoints:         kw.EntryPoints,
+		IntrospectionExport: "pageSettings",
 	})
 	bundlerResult := workflowBuilder.Bundle(ctx)
 	kw.Bundle = bundlerResult

diff --git a/workflowBundler/workflowBundler.go b/workflowBundler/workflowBundler.go
@@ -50,9 +50,6 @@ type (
 )
 
 func NewWorkflowBundler[TSettings any](options BundlerOptions[TSettings]) WorkflowBundler[TSettings] {
-	if options.IntrospectionExport == "" {
-		options.IntrospectionExport = "workflowSettings"
-	}
 	return &builder[TSettings]{
 		bundleOptions: options,
 	}

diff --git a/workflowBundler/workflowBundler_test.go b/workflowBundler/workflowBundler_test.go
@@ -21,8 +21,9 @@ func Test_WorkflowBundler(t *testing.T) {
 	pluginSetupWasCalled := false
 
 	workflowBuilder := NewWorkflowBundler[workflowSettings](BundlerOptions[workflowSettings]{
-		WorkingFolder: workflowPath,
-		EntryPoints:   []string{"tokensWorkflow.ts"},
+		WorkingFolder:       workflowPath,
+		EntryPoints:         []string{"tokensWorkflow.ts"},
+		IntrospectionExport: "workflowSettings",
 		OnDiscovered: func(bundle *BundlerResult[workflowSettings]) {
 			bundle.Errors = append(bundle.Errors, "ID is required")
 		},