Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend default resolution #39

Merged
merged 6 commits into from
Jan 12, 2024
Merged

Extend default resolution #39

merged 6 commits into from
Jan 12, 2024

Conversation

pokornyd
Copy link
Member

@pokornyd pokornyd commented Dec 10, 2023

Motivation

Fixes #20 #23

Adds default resolution method for images, extends all default resolution methods to be optionally usable with Vue

Checklist

  • Code follows coding conventions held in this repo
  • Automated tests have been added
  • Tests are passing
  • Docs have been updated (if applicable)
  • Temporary settings (e.g. variables used during development and testing) have been reverted to defaults

How to test

See HTML transformer or Vue transformer for example use. Documentation should be updated to reflect the universal capability of resolution methods (or they should be separated).

@pokornyd pokornyd requested review from IvanKiral and a team as code owners December 10, 2023 23:25
@pokornyd pokornyd linked an issue Dec 10, 2023 that may be closed by this pull request
@pokornyd pokornyd changed the title Default image resolution Extend default resolution Dec 11, 2023
@pokornyd pokornyd linked an issue Dec 11, 2023 that may be closed by this pull request
@pokornyd pokornyd force-pushed the default-resolution branch 4 times, most recently from b936d38 to eba8b81 Compare December 11, 2023 09:12
Copy link

codecov bot commented Dec 13, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a5abce8) 94.58% compared to head (183b216) 94.79%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #39      +/-   ##
==========================================
+ Coverage   94.58%   94.79%   +0.20%     
==========================================
  Files          17       19       +2     
  Lines         351      365      +14     
  Branches       67       68       +1     
==========================================
+ Hits          332      346      +14     
  Misses         19       19              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pokornyd pokornyd mentioned this pull request Dec 17, 2023
5 tasks
@pokornyd pokornyd requested a review from JiriLojda December 17, 2023 18:31
add resolverMethod type

split resolution methods to standalone files

extend default resolution for vue
@pokornyd pokornyd merged commit b2c3fbd into main Jan 12, 2024
@pokornyd pokornyd deleted the default-resolution branch January 12, 2024 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Define data contract for Vue serializers Add default resolutions for image
2 participants