-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend default resolution #39
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6b648dc
to
650c018
Compare
337241b
to
fb975dd
Compare
b936d38
to
eba8b81
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #39 +/- ##
==========================================
+ Coverage 94.58% 94.79% +0.20%
==========================================
Files 17 19 +2
Lines 351 365 +14
Branches 67 68 +1
==========================================
+ Hits 332 346 +14
Misses 19 19 ☔ View full report in Codecov by Sentry. |
JiriLojda
requested changes
Dec 14, 2023
5bcc38a
to
46e89fd
Compare
46e89fd
to
20a97a8
Compare
add resolverMethod type split resolution methods to standalone files extend default resolution for vue
20a97a8
to
fc26e3e
Compare
fc26e3e
to
183b216
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Fixes #20 #23
Adds default resolution method for images, extends all default resolution methods to be optionally usable with Vue
Checklist
How to test
See HTML transformer or Vue transformer for example use. Documentation should be updated to reflect the universal capability of resolution methods (or they should be separated).