Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

koordlet: refactor node metrics to tsdb #1316

Merged

Conversation

LambdaHJ
Copy link
Contributor

Ⅰ. Describe what this PR does

Ⅱ. Does this pull request fix one issue?

fixes #1287.

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

@codecov
Copy link

codecov bot commented May 21, 2023

Codecov Report

Patch coverage: 53.38% and project coverage change: -0.11 ⚠️

Comparison is base (f81bbd8) 64.72% compared to head (cb12c09) 64.62%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1316      +/-   ##
==========================================
- Coverage   64.72%   64.62%   -0.11%     
==========================================
  Files         322      324       +2     
  Lines       33533    33492      -41     
==========================================
- Hits        21704    21643      -61     
- Misses      10257    10274      +17     
- Partials     1572     1575       +3     
Flag Coverage Δ
unittests 64.62% <53.38%> (-0.11%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/koordlet/metriccache/metric_cache.go 48.65% <0.00%> (-2.34%) ⬇️
pkg/koordlet/metriccache/metric_result.go 56.71% <0.00%> (-4.58%) ⬇️
pkg/koordlet/metriccache/metric_types.go 72.22% <0.00%> (-6.57%) ⬇️
pkg/koordlet/metriccache/util.go 76.62% <ø> (+6.00%) ⬆️
...ordlet/metricsadvisor/devices/gpu/collector_gpu.go 0.00% <0.00%> (ø)
pkg/koordlet/util/device.go 0.00% <0.00%> (ø)
pkg/koordlet/resmanager/cpu_suppress.go 70.37% <33.33%> (-0.97%) ⬇️
pkg/koordlet/resmanager/memory_evict.go 68.29% <38.46%> (-1.80%) ⬇️
pkg/koordlet/resmanager/cpu_burst.go 70.96% <42.10%> (-1.54%) ⬇️
pkg/koordlet/statesinformer/states_nodemetric.go 56.95% <54.28%> (-4.70%) ⬇️
... and 4 more

... and 7 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@zwzhang0107 zwzhang0107 changed the title refactor node metrics to tsdb koordlet: refactor node metrics to tsdb May 22, 2023
pkg/koordlet/resmanager/cpu_suppress.go Outdated Show resolved Hide resolved
pkg/koordlet/resmanager/metrics_query.go Outdated Show resolved Hide resolved
pkg/koordlet/qosmanager/metricsquery/metrics_query_test.go Outdated Show resolved Hide resolved
pkg/koordlet/metriccache/metric_cache.go Outdated Show resolved Hide resolved
pkg/koordlet/metriccache/metric_cache.go Outdated Show resolved Hide resolved
@zwzhang0107
Copy link
Contributor

nice job!!

@LambdaHJ LambdaHJ force-pushed the refactor-node-mectirs-collector branch from b85fcd4 to 53311b0 Compare May 23, 2023 08:57
@LambdaHJ LambdaHJ force-pushed the refactor-node-mectirs-collector branch 2 times, most recently from 9a3e6e3 to 4cd6d58 Compare May 24, 2023 04:52
@LambdaHJ LambdaHJ force-pushed the refactor-node-mectirs-collector branch from 4cd6d58 to ab4f17d Compare May 24, 2023 07:05
@LambdaHJ LambdaHJ force-pushed the refactor-node-mectirs-collector branch from ab4f17d to 4143f69 Compare May 24, 2023 08:09
@zwzhang0107
Copy link
Contributor

/lgtm
/approve

Signed-off-by: 黄金 <[email protected]>

# Conflicts:
#	pkg/koordlet/metricsadvisor/framework/plugin.go
@LambdaHJ LambdaHJ force-pushed the refactor-node-mectirs-collector branch from 4143f69 to cb12c09 Compare May 25, 2023 01:50
@koordinator-bot koordinator-bot bot removed the lgtm label May 25, 2023
Copy link
Member

@jasonliu747 jasonliu747 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work buddy!
/lgtm

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jasonliu747, zwzhang0107

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit 592bcc9 into koordinator-sh:main May 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[proposal]refactor node metircs cache to tsdb
3 participants