-
Notifications
You must be signed in to change notification settings - Fork 340
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
koordlet: refactor node metrics to tsdb #1316
koordlet: refactor node metrics to tsdb #1316
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1316 +/- ##
==========================================
- Coverage 64.72% 64.62% -0.11%
==========================================
Files 322 324 +2
Lines 33533 33492 -41
==========================================
- Hits 21704 21643 -61
- Misses 10257 10274 +17
- Partials 1572 1575 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
nice job!! |
b85fcd4
to
53311b0
Compare
pkg/koordlet/metricsadvisor/collectors/noderesource/node_resource_collector.go
Show resolved
Hide resolved
pkg/koordlet/metricsadvisor/collectors/noderesource/node_resource_collector.go
Outdated
Show resolved
Hide resolved
Signed-off-by: 黄金 <[email protected]>
9a3e6e3
to
4cd6d58
Compare
4cd6d58
to
ab4f17d
Compare
ab4f17d
to
4143f69
Compare
/lgtm |
Signed-off-by: 黄金 <[email protected]> # Conflicts: # pkg/koordlet/metricsadvisor/framework/plugin.go
4143f69
to
cb12c09
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work buddy!
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jasonliu747, zwzhang0107 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Ⅰ. Describe what this PR does
Ⅱ. Does this pull request fix one issue?
fixes #1287.
Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews
V. Checklist
make test