-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
KEP-672: Implement the DependsOn API #740
KEP-672: Implement the DependsOn API #740
Conversation
@andreyvelich: GitHub didn't allow me to request PR reviews from the following users: vsoch. Note that only kubernetes-sigs members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Hi @andreyvelich. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
✅ Deploy Preview for kubernetes-sigs-jobset canceled.
|
/ok-to-test |
I've added integration and unit tests. Let me know if that looks good to you! |
@andreyvelich: GitHub didn't allow me to assign the following users: vsoch, shravan-achar, akshaychitneni. Note that only kubernetes-sigs members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Improve API docs
Rename func to dependencyReachedStatus
Add info for Suspended Job
Improve docs
9eac93e
to
4c238e6
Compare
/lgtm Thanks @andreyvelich, this is a great feature, the implementation is clean and the testing is thorough! Feel free to remove the hold if others don't have anymore feedback. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahg-g, andreyvelich, vsoch The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Thanks everyone for the review 🎉 |
What type of PR is this?
/kind feature
/kind api-change
What this PR does / why we need it:
I added implementation for the DependsOn API. The majority of validations are implemented using CEL.
TODO list:
depends_on.go
/cc @ahg-g @kannon92 @danielvegamyhre @tenzen-y @vsoch
Which issue(s) this PR fixes:
Fixes: #672
Does this PR introduce a user-facing change?