Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KEP-672: Implement the DependsOn API #740

Merged

Conversation

andreyvelich
Copy link
Member

@andreyvelich andreyvelich commented Dec 27, 2024

What type of PR is this?

/kind feature
/kind api-change

What this PR does / why we need it:

I added implementation for the DependsOn API. The majority of validations are implemented using CEL.

TODO list:

  • Add unit tests for the depends_on.go
  • Add controller integration tests to verify CEL validation.
  • Add controller integration tests to verify Job creation.

/cc @ahg-g @kannon92 @danielvegamyhre @tenzen-y @vsoch

Which issue(s) this PR fixes:

Fixes: #672

Does this PR introduce a user-facing change?

Add the DependsOn API to support serial execution of ReplicatedJobs.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 27, 2024
@k8s-ci-robot k8s-ci-robot requested a review from ahg-g December 27, 2024 13:17
@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API labels Dec 27, 2024
@k8s-ci-robot
Copy link
Contributor

@andreyvelich: GitHub didn't allow me to request PR reviews from the following users: vsoch.

Note that only kubernetes-sigs members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

What type of PR is this?

/kind feature
/kind api-change

What this PR does / why we need it:

I added implementation for the DependsOn API. The majority of validations are implemented using CEL.

TODO list:

  • Add unit tests for the depends_on.go
  • Add controller integration tests to verify CEL validation.
  • Add controller integration tests to verify Job creation.

/cc @ahg-g @kannon92 @danielvegamyhre @tenzen-y @vsoch

Which issue(s) this PR fixes:

Fixes: #672

Does this PR introduce a user-facing change?

Add the DependsOn API to support serial execution of ReplicatedJobs.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 27, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @andreyvelich. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Dec 27, 2024
Copy link

netlify bot commented Dec 27, 2024

Deploy Preview for kubernetes-sigs-jobset canceled.

Name Link
🔨 Latest commit d208d27
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-jobset/deploys/67970519a1e81f0008ff422f

@kannon92
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Dec 27, 2024
@andreyvelich
Copy link
Member Author

I've added integration and unit tests. Let me know if that looks good to you!
/assign @ahg-g @kannon92 @danielvegamyhre @tenzen-y @vsoch @shravan-achar @akshaychitneni

@k8s-ci-robot
Copy link
Contributor

@andreyvelich: GitHub didn't allow me to assign the following users: vsoch, shravan-achar, akshaychitneni.

Note that only kubernetes-sigs members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

I've added integration and unit tests. Let me know if that looks good to you!
/assign @ahg-g @kannon92 @danielvegamyhre @tenzen-y @vsoch @shravan-achar @akshaychitneni

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@andreyvelich andreyvelich changed the title [WIP] KEP-672: Implement the DependsOn API KEP-672: Implement the DependsOn API Jan 3, 2025
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 3, 2025
@andreyvelich andreyvelich force-pushed the issue-672-implement-depends-on branch from 9eac93e to 4c238e6 Compare January 27, 2025 00:50
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 27, 2025
@ahg-g
Copy link
Contributor

ahg-g commented Jan 27, 2025

/lgtm
/approve

Thanks @andreyvelich, this is a great feature, the implementation is clean and the testing is thorough! Feel free to remove the hold if others don't have anymore feedback.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 27, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahg-g, andreyvelich, vsoch

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 27, 2025
@andreyvelich
Copy link
Member Author

Thanks everyone for the review 🎉
/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 27, 2025
@k8s-ci-robot k8s-ci-robot merged commit ec94252 into kubernetes-sigs:main Jan 27, 2025
13 checks passed
@andreyvelich andreyvelich deleted the issue-672-implement-depends-on branch January 27, 2025 13:15
@kannon92 kannon92 mentioned this pull request Feb 26, 2025
20 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for the execution policy API in JobSet
7 participants